-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wxGUI/history: add pop-up command menu with an item for delete command from history + history tree refactoring #3342
Merged
petrasovaa
merged 4 commits into
OSGeo:main
from
lindakarlovska:wxGUI-delete-history-cmd-entry
Jan 18, 2024
Merged
wxGUI/history: add pop-up command menu with an item for delete command from history + history tree refactoring #3342
petrasovaa
merged 4 commits into
OSGeo:main
from
lindakarlovska:wxGUI-delete-history-cmd-entry
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1d9f733
to
845daff
Compare
petrasovaa
reviewed
Jan 8, 2024
petrasovaa
reviewed
Jan 8, 2024
petrasovaa
reviewed
Jan 8, 2024
petrasovaa
reviewed
Jan 8, 2024
petrasovaa
reviewed
Jan 8, 2024
petrasovaa
reviewed
Jan 17, 2024
petrasovaa
reviewed
Jan 17, 2024
petrasovaa
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just couple small notes, otherwise it's ready.
441d357
to
e3ab37d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is largely based on #3310.
It implements new functionality with a pop-up command menu with an item for deleting commands from the history log and at the same time also makes some necessary changes in API to ensure better code maintenance in the future.
The API logic for the History panel respects the API used for the Data Catalog.
Main changes in API:
Fixes: