-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure: enable read Git hash and date from file #3435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve the concept, and the overall implementation. I cannot confirm that it is correctly implemented though.
Updated with fixed tests.
|
Added |
3753e59
to
b0b5dea
Compare
I tested this PR by creating
In this case Git hash should be propagated from the file @nilason right? |
True, corrected this with d9bca18. |
d9bca18
to
1b4e18f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only worries were validated by multiple other members in the comments. So, I consider it good to go!
Enable configure to read
GRASS_HEADERS_GIT_HASH
andGRASS_HEADERS_GIT_DATE
from a fileinclude/VERSION_GIT
(if it exist). That file can be generated in the process of packaging the release tarball, leading to consistent versioning even without Git.The VERSION_GIT file is expected to contain:
First step in solving #3430.