i.emissivity: added test file for i.emissivity module #5127
Conversation
github-actions
bot
added
Python
| self.temp_rasters.append("diff_raster") | ||
|
|
||
| self.assertRasterMinMax("diff_raster", 0, 0.05) | ||
| self.runModule("r.mask", flags="r") |
There was a problem hiding this comment.
You need to remove the mask before you test the outputs.
It should be enough to check with assertRasterFitsUnivar, e.g., the mean, min, max and non-null cells.
There was a problem hiding this comment.
Thanks for the feedback! I have removed the mask before testing the outputs and updated the test to use assertRasterFitsUnivar to check the mean, min and max as suggested.
| def test_region_resolution(self): | ||
| """Test the module behaviour with different region resolutions.""" | ||
| results = {} | ||
| for res in [1, 0.1]: | ||
| with self.subTest(res=res): | ||
| self.runModule("g.region", n=10, s=0, e=10, w=0, res=res) | ||
| self.runModule( | ||
| "r.mapcalc", expression=f"{self.input_raster} = 0.6", overwrite=True | ||
| ) | ||
| self.assertModule( | ||
| "i.emissivity", | ||
| input=self.input_raster, | ||
| output=self.output_raster, | ||
| overwrite=True, | ||
| ) | ||
| results[res] = self.assertRasterMinMax(self.output_raster, 0, 1) | ||
|
|
||
| self.assertAlmostEqual(results[1], results[0.1], delta=0.01) |
There was a problem hiding this comment.
I don't see much value in this test for i.emissivity specifically
There was a problem hiding this comment.
I have replaced the previous test with the new one focused on default emissivity calculation using critical NDVI values. This ensures that if the module is changed in the future, the test will catch it by failing.
| overwrite=True, | ||
| ) | ||
| self.assertRasterExists(self.output_raster) | ||
| self.assertRasterMinMax(self.output_raster, 0, 1) |
There was a problem hiding this comment.
I would test with assertRasterFitsUnivar
There was a problem hiding this comment.
I have updated the test to use assertRasterFitsUnivar for validation.
This PR introduces a comprehensive test suite for the
i.emissivityGRASS GIS module. The test suite is designed to validate core functionality, assess statistical correctness, and handle edge cases to ensure robust module behavior.Key Updates in this PR:
Test Case Additions
Basic Functionality
test_emissivity_ndvi_range).test_complex_mask).Advanced Properties
test_region_resolution).test_partial_null_values).test_extreme_ndvi_values).Performance
Future Enhancements
This test suite enhances the reliability of the
i.emissivitymodule by covering a broad spectrum of cases. Looking forward to feedback and potential refinements!