t.rast.extract: Handle fully qualified map names and semantic labels #6300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoix
reviewed
Sep 2, 2025
Comment on lines
167
to
170
| for k, v in expected_info.items(): | ||
| assert ( | ||
| strds_info[k] == v | ||
| ), f"Expected value for key '{k}' is {v}. Got: {strds_info[k]}" |
There was a problem hiding this comment.
Was the default behavior of pytest not enough for dictionaries when developing your tests?
(Like for a bad value, missing, and extra keys)
There was a problem hiding this comment.
I wanted to check only a subset of the metadata keys. And unfortunately, it did not print out the key when I compared values are as expected. Are you aware of any build-in methods in pytest that would allow to test if a dictionary is covered by another (regardless of the order of keys and the like...)? I would be happy to adjust and drop the loop...
wenzeslaus
requested changes
Sep 3, 2025
temporal/t.rast.extract/testsuite/test_t_rast_extract_pytest.py
Outdated
Show resolved
Hide resolved
temporal/t.rast.extract/testsuite/test_t_rast_extract_pytest.py
Outdated
Show resolved
Hide resolved
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
temporal/t.rast.extract/testsuite/test_t_rast_extract_pytest.py
Outdated
Show resolved
Hide resolved
temporal/t.rast.extract/testsuite/test_t_rast_extract_pytest.py
Outdated
Show resolved
Hide resolved
temporal/t.rast.extract/testsuite/test_t_rast_extract_pytest.py
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
I had to address semantic_labels better as well. They were introduced after the extract module was created... The new tests cover semantic labels... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR appends semantic labels to the basename when expression is given for extraction of raster maps and handles fully qualified STRDS names more reliably. It also adds a pytest based testcase.
Fixes #6254