Full Migration pysap from Python 2.7 to Python 3#84
Open
vah13 wants to merge 1 commit intoOWASP:masterfrom
Open
Full Migration pysap from Python 2.7 to Python 3#84vah13 wants to merge 1 commit intoOWASP:masterfrom
vah13 wants to merge 1 commit intoOWASP:masterfrom
Conversation
Full migration of the pysap library to Python 3 with support for Python 3.9 through 3.12 on Linux, macOS and Windows. Core changes: - Replaced deprecated Python 2 imports (cStringIO, SocketServer, Queue) - Ported the pysapcompress C extension to the Python 3 module API - Fixed string vs bytes handling across all SAP protocol modules - Updated the cryptographic routines for proper bytes operations - Resolved scapy 2.7 compatibility issues with duplicate field names Infrastructure: - Modernized the CI/CD pipeline to test against Python 3.9-3.12 - Updated all dependency versions for Python 3 compatibility - Adapted the full test suite to work with Python 3 semantics
codeHorse87
reviewed
Mar 26, 2026
Contributor
codeHorse87
left a comment
codeHorse87
left a comment
There was a problem hiding this comment.
Hi @vah13 thanks a lot for the PR which looks very promissing. I'm currently quite occupied to conduct a comprehensive review, as well as I'm missing some permission on the repo atm.
I'm not sure if @martingalloar meanwhile can support with the code review meanwhile? I'll do my very best to create a test setup and check with a SAP testing environment.
Contributor
Author
|
Hello, I can share with you the demo environment of SAP S4 2025 for testing. |
|
@vah13, thanks! Currently totally occupied but when there is some time later I will definitely test with it. Long awaited this thing so thanks for doing this |
|
@codeHorse87 - connect on this? Maybe I can support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full migration of the pysap library to Python 3 with support for Python 3.9 through 3.12 on Linux, macOS and Windows.
Core changes:
Infrastructure: