Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support un signed auth request #10

Merged
merged 12 commits into from
Jun 20, 2024
Merged

support un signed auth request #10

merged 12 commits into from
Jun 20, 2024

Conversation

ryosuke-wakaba
Copy link
Collaborator

@ryosuke-wakaba ryosuke-wakaba commented Jun 18, 2024 •
edited
Loading

The following fixes were made to the processing of unsigned authorization requests:

  • Determine whether the request or request_uri in the authorization request URL is signed or not
  • If the request is signed, obtain parameters from the Request Object and deserialize them
  • If the request is unsigned, obtain parameters from the query parameters and deserialize them

@ryosuke-wakaba ryosuke-wakaba changed the title Feature/support un signed auth request [WIP] Feature/support un signed auth request Jun 18, 2024
@ryosuke-wakaba ryosuke-wakaba changed the title [WIP] Feature/support un signed auth request support un signed auth request Jun 19, 2024
@ryosuke-wakaba ryosuke-wakaba requested a review from moratori June 20, 2024 05:52
moratori
moratori approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@moratori moratori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryosuke-wakaba
Merge branch 'refs/heads/main' into feature/support_un_signed_auth_re…
5a6dcc6 
…quest

# Conflicts:
#	app/src/main/java/com/ownd_project/tw2023_wallet_android/oid/OpenIdProvider.kt
@ryosuke-wakaba
format
0d18278
@moratori moratori merged commit a5cde98 into OWND-Project:main Jun 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moratori moratori moratori approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryosuke-wakaba @moratori