Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Pattern Tests for Authorization Request in OpenIdProviderTest #11

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

ryosuke-wakaba
Copy link
Collaborator

@ryosuke-wakaba ryosuke-wakaba commented Jun 27, 2024

Added Pattern Tests for Authorization Request in OpenIdProviderTest

Added Test Cases:

  • Case where client_id_scheme is x509_san_dns
  • Case where client_id_scheme is redirect_uri
  • Case for unsigned requests in SIOPv2

Additionally, modified interfaces where Result type is more appropriate than Either type due to changes in the tests.

@ryosuke-wakaba ryosuke-wakaba changed the title Add for request test of OpenIdProviderTest.kt Added Pattern Tests for Authorization Request in OpenIdProviderTest Jun 27, 2024
Copy link
Member

@moratori moratori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@moratori moratori merged commit 1023914 into OWND-Project:main Jul 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants