Add editorconfig and prettier to project #533
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many styling inconsistencies through the project:
This is a common result of open source projects that without formatter/linter due to different editor setups per user.
In this PR I've added an editorconfig for live formatting and prettier for post formatting.
I've also added a precommit hook to run prettier on all staged files upon a commit. This will further ensure styling stays consistent.
I've gone ahead and ran prettier against the entire code base to fix all styling issues via
npx prettier . --write
. However, some of the styling choices I've made are arbitrary and are absolutely up for discussion.