fix(float-window-manager): sway version compare#51
Open
sakarie9 wants to merge 1 commit intoOctopusET:masterfrom
Open
fix(float-window-manager): sway version compare#51sakarie9 wants to merge 1 commit intoOctopusET:masterfrom
sakarie9 wants to merge 1 commit intoOctopusET:masterfrom
Conversation
scott092707
reviewed
Feb 19, 2025
Contributor
|
I just added (to mine) a notify-send for this, as if it doesn't start, the user ought to know why without needing to look at the log: |
Contributor
|
[Wasn't sure how to do this officially, as your change has not yet reached the official code...] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String compare will cause issues like "1.10.1 is smaller than 1.6".
We can use
sort -Vinstead.