Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: clean up validation and add factory getters #32

Merged
merged 15 commits into from
Feb 29, 2024
Merged

refactor: clean up validation and add factory getters #32

merged 15 commits into from
Feb 29, 2024

Conversation

douglance
Copy link
Contributor

@douglance douglance commented Dec 22, 2023 •
edited
Loading

pulls out getValidChainId and getRollupCreatorAddress into a new utils file getters.ts

open to ideas for a better name for the file

@douglance douglance marked this pull request as ready for review December 27, 2023 18:09
@douglance douglance requested a review from spsjvc December 27, 2023 18:09
@douglance douglance changed the title feat: adds Orbit Client extension feat: pulls out chain validation and getting rollupCreatorAddress into functions Dec 27, 2023
@douglance douglance changed the title feat: pulls out chain validation and getting rollupCreatorAddress into functions feat: refactors chain and address validation Dec 27, 2023
@spsjvc spsjvc changed the title feat: refactors chain and address validation refactor: clean up parent chain validation and add factory getters Feb 29, 2024
@spsjvc spsjvc changed the title refactor: clean up parent chain validation and add factory getters refactor: clean up validation and add factory getters Feb 29, 2024
@spsjvc spsjvc enabled auto-merge (squash) February 29, 2024 12:17
@spsjvc spsjvc merged commit 5a341c1 into main Feb 29, 2024
5 of 6 checks passed
@spsjvc spsjvc deleted the dl/orbit-client branch February 29, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spsjvc spsjvc spsjvc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@douglance @spsjvc