Replay run mode #320
Merged
Replay run mode #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlasmaPower
suggested changes
May 28, 2024
| @@ -80,7 +80,7 @@ func (p *StateProcessor) Process(block *types.Block, statedb *state.StateDB, cfg | |||
| } | |||
| // Iterate over and process the individual transactions | |||
| for i, tx := range block.Transactions() { | |||
| msg, err := TransactionToMessage(tx, signer, header.BaseFee) | |||
| msg, err := TransactionToMessage(tx, signer, header.BaseFee, MessageCommitMode) | |||
There was a problem hiding this comment.
In Arbitrum, I think this is used by state recreation, not commit mode
There was a problem hiding this comment.
Changed that.
But we need to remember that, for when we switch to a more POS-like block addition.
internal/ethapi/api.go
Outdated
| @@ -1155,7 +1155,7 @@ func runScheduledTxes(ctx context.Context, b core.NodeInterfaceBackendAPI, state | |||
| scheduled := result.ScheduledTxes | |||
| for runMode == core.MessageGasEstimationMode && len(scheduled) > 0 { | |||
| // This will panic if the scheduled tx is signed, but we only schedule unsigned ones | |||
| msg, err := core.TransactionToMessage(scheduled[0], types.NewArbitrumSigner(nil), header.BaseFee) | |||
| msg, err := core.TransactionToMessage(scheduled[0], types.NewArbitrumSigner(nil), header.BaseFee, core.MessageReplayMode) | |||
There was a problem hiding this comment.
I don't think this is replay mode, I think it should use runMode. In fact, we currently override it below, which could be replaced by this parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
creates a new runmode for replaying message, which should produce same result as messageCommit but not be expected to be latest block