Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use persisted basefee in txProcessor hooks and ArbGasInfo precompile when basefee is lowered to 0 #2358

Merged
merged 6 commits into from
Jun 18, 2024

Conversation

ganeshvanahalli
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli commented May 30, 2024

pulls in OffchainLabs/go-ethereum#324 which enables lowering of basefee to 0 to preserve EVM invariant basefee < feecap (previously disabled for arbitrum chains)

Resolves NIT-2412

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label May 30, 2024
@ganeshvanahalli ganeshvanahalli marked this pull request as ready for review May 30, 2024 22:14
Tristan-Wilson
Tristan-Wilson previously approved these changes May 31, 2024
Copy link
Member

@Tristan-Wilson Tristan-Wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tristan-Wilson
Tristan-Wilson previously approved these changes May 31, 2024
anodar
anodar previously approved these changes Jun 3, 2024
amsanghi
amsanghi previously approved these changes Jun 5, 2024
@ganeshvanahalli ganeshvanahalli merged commit 1fe576b into master Jun 18, 2024
11 checks passed
@ganeshvanahalli ganeshvanahalli deleted the allow-zeroing-blockctxbasefee branch June 18, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants