Utilize BalanceChangeReason in tracing #2789
Open
+99
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
eljobe
previously approved these changes
Jan 15, 2025
|
@ganeshvanahalli, can you resolve the merge conflicts so we can get this merged? |
@eljobe, I've resolved the conflicts but the corresponding geth PR needs a review before we merge this in. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2789 +/- ##
==========================================
+ Coverage 22.56% 22.61% +0.04%
==========================================
Files 269 269
Lines 39923 39922 -1
==========================================
+ Hits 9009 9028 +19
+ Misses 29438 29420 -18
+ Partials 1476 1474 -2 |
tsahee
added
the
after-next-version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables usage of BalanceChangeReason type in tracing, and also enables tracing of balance changes involved in a transaction using
jsTracer(sample trace has been printed out from a system_test), enabling clearer way to reason with the balance changes of almost all transaction types.Pulls in geth PR- OffchainLabs/go-ethereum#375
Resolves NIT-2943