Skip to content

Conversation

MishkaRogachev
Copy link
Contributor

@MishkaRogachev MishkaRogachev commented Oct 7, 2025

Copy link

github-actions bot commented Oct 7, 2025

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
2141 4 2137 0
View the top 3 failed tests by shortest run time
TestDataStreaming_PositiveScenario/Many_senders,_long_messages
Stack Traces | 0.270s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic.func1()
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:248 +0x14f
        created by github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic in goroutine 155
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:241 +0x85
        
    protocol_test.go:248: �[31;1m [] failed after 3 attempts: too much time has elapsed since request was signed �[0;0m
INFO [10-14|13:52:13.242] rpc response                             method=datastreaming_start logId=421 err="too much time has elapsed since request was signed" result={} attempt=0 args="[\"0x68ee558c\", \"0x35\", \"0xd9\", \"0x2c67\", \"0xa\", \"0x49f942e361e3701909c67b999d7b41a75592fb6297ad9c68216a3ddcf85cf0304483b7789ceedb280b9dadbdf93bab8b930a467054ebe4e3fecf293af5ad4d2f01\"]" errorData=null
    protocol_test.go:248: goroutine 161 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x1567e90, 0xc0005948c0}, {0x154d960, 0xc000cb82e0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic.func1()
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:248 +0x14f
        created by github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic in goroutine 155
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:241 +0x85
        
    protocol_test.go:248: �[31;1m [] failed after 3 attempts: too much time has elapsed since request was signed �[0;0m
--- FAIL: TestDataStreaming_PositiveScenario/Many_senders,_long_messages (0.27s)
TestDataStreaming_PositiveScenario
Stack Traces | 0.290s run time
=== RUN   TestDataStreaming_PositiveScenario
--- FAIL: TestDataStreaming_PositiveScenario (0.29s)
TestOutOfGasInStorageCacheFlush
Stack Traces | 20.190s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
TRACE[10-14|13:55:47.447] P2P networking is spinning down
    program_test.go:2813: goroutine 683649 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x4082330, 0xc12e7bb180}, {0x4040100, 0xc0d118b780}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc12e7bb180, {0x4040100, 0xc0d118b780}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1723 +0x5d
        github.com/offchainlabs/nitro/system_tests.TestOutOfGasInStorageCacheFlush(0xc12e7bb180)
        	/home/runner/work/nitro/nitro/system_tests/program_test.go:2813 +0xfe6
        testing.tRunner(0xc12e7bb180, 0x3cca398)
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1997 +0x465
        
    program_test.go:2813: �[31;1m [] failed calculating position for validation: batch not found on L1 yet �[0;0m
ERROR[10-14|13:56:04.427] Dangling trie nodes after full cleanup
INFO [10-14|13:56:04.447] HTTP server stopped                      endpoint=127.0.0.1:46261
TRACE[10-14|13:56:04.448] P2P networking is spinning down
--- FAIL: TestOutOfGasInStorageCacheFlush (20.19s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@MishkaRogachev MishkaRogachev force-pushed the check-multi-dimensional-gas-in-block-re-execution branch from 8380e75 to f76ff64 Compare October 8, 2025 09:30
@MishkaRogachev MishkaRogachev marked this pull request as ready for review October 8, 2025 10:27
Copy link
Contributor

@gligneul gligneul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just minor comments.

@gligneul gligneul assigned MishkaRogachev and unassigned gligneul Oct 8, 2025
@gligneul gligneul assigned eljobe and unassigned gligneul Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants