Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orbit upgrade action for contracts v2.1.0 #16

Merged
merged 86 commits into from
Aug 20, 2024
Merged

Orbit upgrade action for contracts v2.1.0 #16

merged 86 commits into from
Aug 20, 2024

Conversation

gvladika
Copy link
Contributor

@gvladika gvladika commented Jul 12, 2024 •
edited
Loading

Contains:

  • upgrade action to upgrade contracts to v2.1.0
    • upgrade ChallengeManager and set new OSP and wasm root (v2.1.0, arbos31), and conditional OSP and wasmRoot (v1.3.0, arbos20)
    • upgrade rollup admin logic and rollup user logic to enable fast withdrawals feature
  • deployer script for upgrade action
  • executor script for upgrade action
  • action for child chain which sets wasm cache manager
  • deployer for cache manager action
  • updates for versioner script which checks upgrade paths

@gvladika gvladika changed the title Upg 2.0.0 Orbit upgrade action for contracts v2.0.0 Jul 17, 2024
@gvladika gvladika marked this pull request as ready for review July 17, 2024 13:03
godzillaba
godzillaba reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@godzillaba godzillaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just have a few minor suggestions. i haven't checked the metadata hashes or the upgrade paths in orbitVersioner yet

contracts/child-chain/stylus/AddWasmCacheManagerAction.sol Outdated Show resolved Hide resolved
contracts/parent-chain/contract-upgrades/NitroContracts2Point0Point0UpgradeAction.sol Outdated Show resolved Hide resolved
contracts/parent-chain/contract-upgrades/NitroContracts2Point0Point0UpgradeAction.sol Outdated Show resolved Hide resolved
scripts/orbit-versioner/orbitVersioner.ts Outdated Show resolved Hide resolved
scripts/foundry/contract-upgrades/2.0.0/README.md Outdated Show resolved Hide resolved
leeederek
leeederek reviewed Aug 14, 2024
View reviewed changes
README.md Show resolved Hide resolved
leeederek
leeederek reviewed Aug 14, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
leeederek
leeederek reviewed Aug 14, 2024
View reviewed changes
README.md Show resolved Hide resolved
gvladika and others added 8 commits August 14, 2024 16:03
@gvladika @leeederek
Update README.md
78df79c 
Co-authored-by: Derek <[email protected]>
@gvladika @leeederek
Update README.md
9a8692c 
Co-authored-by: Derek <[email protected]>
@gzeoneth
fix: fast confirm safe customizable salt (#19)
be621c9 
* fix: fast confirm safe customizable salt

* chore: update sigs

* docs: salt

* chore: update testnet deployments
@gvladika
Minor improvements and output files
fdb1b39
@gzeoneth
feat: custom threshold in EnableFastConfirmAction (#20)
6112142 
* feat: custom threshold in EnableFastConfirmAction

* docs: update readme

* chore: update sigs

* fix: lint
@gzeoneth
fix: arbsys mock for deployment
5d79a05
@gzeoneth
chore: 2.1.0 upgrade action deployments
aeb81db
@gzeoneth
chore: fast confirm action deployments
1746e9e
@gzeoneth gzeoneth merged commit 9e73bef into main Aug 20, 2024
8 checks passed
@gzeoneth gzeoneth deleted the upg-2.0.0 branch August 20, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godzillaba godzillaba godzillaba left review comments

@leeederek leeederek leeederek left review comments

@gzeoneth gzeoneth gzeoneth approved these changes

@yahgwai yahgwai Awaiting requested review from yahgwai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gvladika @godzillaba @gzeoneth @leeederek