Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compsupp-7678] Inner Column Style Background image is not translatable #410

Closed
wants to merge 1 commit into from

Conversation

Kitilyes
Copy link
Contributor

Using Uncode theme with WPBakery builder; the back_image attribute in the vc_column_inner shortcode is not automatically translated. This leads to the same image displaying across all languages. This Commit will register the background image for both inner (vc_column_inner) and outer columns (vc_column).

Youtrack : https://onthegosystems.myjetbrains.com/youtrack/issue/compsupp-7678

…ated

Using Uncode theme with WPBakery builder; the back_image attribute in the vc_column_inner shortcode is not automatically translated. This leads to the same image displaying across all languages.
This Commit will register the background image for both inner 
(vc_column_inner) and outer columns (vc_column). 

Youtrack : https://onthegosystems.myjetbrains.com/youtrack/issue/compsupp-7678
@strategio
Copy link
Member

@Kitilyes, let's wait for #411 before applying anything because we'll have a conflict with this Uncode file.

But please read my comment for Nicolas, I would ask you the same.

@strategio
Copy link
Member

@Kitilyes, I've merged #411, so now you have to rebase and solve conflicts, or maybe just re-create your branch from the updated master.

Sorry, you should have had the priority because your PR id is lower, but didn't imagine that you were both working on the same config.

@Kitilyes
Copy link
Contributor Author

Kitilyes commented Nov 29, 2024

@strategio No problem, I created a new PR using the updated master #413 , we can close #410

@strategio strategio closed this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants