Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SiteOrigin XML definitions #416

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Remove SiteOrigin XML definitions #416

merged 1 commit into from
Dec 31, 2024

Conversation

dgwatkins
Copy link
Collaborator

SiteOrigin is maintaining these files in their plugins and they aren't doing anything here.

https://onthegosystems.myjetbrains.com/youtrack/issue/wpmlpb-430/

SiteOrigin is maintaining these files in their plugins and they aren't doing anything here.

https://onthegosystems.myjetbrains.com/youtrack/issue/wpmlpb-430/
@dgwatkins dgwatkins requested a review from strategio December 30, 2024 14:09
@strategio
Copy link
Member

@dgwatkins, do you know when SiteOrigin started maintaining their XML config locally?

I am asking because we made some changes changes here in the 2 last years => https://github.com/OnTheGoSystems/wpml-config/commits/master/siteorigin/wpml-config.xml

So if we made changes here, I believe it's because it was applied (we should have tested it manually) and as a consequence, the local config was missing.

@dgwatkins
Copy link
Collaborator Author

@dgwatkins, do you know when SiteOrigin started maintaining their XML config locally?

We aren't overriding their local XML, so all these changes had no effect @strategio

@dgwatkins
Copy link
Collaborator Author

I am asking because we made some changes changes here in the 2 last years => https://github.com/OnTheGoSystems/wpml-config/commits/master/siteorigin/wpml-config.xml

Those changes have already been pushed and merged to the author's repo.

@strategio
Copy link
Member

@dgwatkins, I could see that we were not overriding the XML config.
But you didn't reply to my question: If we made changes to our remote repo less than 1 year ago, it means it was taking effect, right?
So my question again: When did SiteOrigin started providing a local XML config?

@dgwatkins
Copy link
Collaborator Author

@dgwatkins, I could see that we were not overriding the XML config. But you didn't reply to my question: If we made changes to our remote repo less than 1 year ago, it means it was taking effect, right?

Theoretically yes, but we must have done something wrong because they added their XML configuration more than 3 years ago:

https://github.com/siteorigin/siteorigin-panels/commits/develop/wpml-config.xml
https://github.com/siteorigin/so-widgets-bundle/commits/develop/wpml-config.xml

Copy link
Member

@strategio strategio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgwatkins dgwatkins merged commit 2fe4655 into master Dec 31, 2024
1 check passed
@dgwatkins dgwatkins deleted the wpmlpb-430 branch December 31, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants