Merge pull request #343 from OneSignal/add-cache-busting-to-admin-script

Add cache-busting query param when loading CSS and JS scripts
OneSignal · Jan 16, 2025 · 9a79f3a · 9a79f3a
2 parents 2d79816 + fee7554
commit 9a79f3a
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 6 deletions.
diff --git a/v3/onesignal-admin/onesignal-admin.php b/v3/onesignal-admin/onesignal-admin.php
@@ -16,8 +16,14 @@ function onesignal_admin_menu()
 
 function admin_files()
 {
-  wp_enqueue_script('onesignal_admin_js', plugins_url('onesignal-admin.js', __FILE__));
-  wp_enqueue_style('style', plugins_url('onesignal-admin.css', __FILE__), array(), time());
+  $cache_buster = ceil(time() / 3600); // updates every hour
+  wp_enqueue_script(
+    'onesignal_admin_js',
+    plugins_url('onesignal-admin.js', __FILE__),
+    array(),
+    $cache_buster
+  );
+  wp_enqueue_style('style', plugins_url('onesignal-admin.css', __FILE__), array(), $cache_buster);
 }
 
 if (isset($_SERVER['REQUEST_METHOD']) && $_SERVER['REQUEST_METHOD'] === 'POST') {

diff --git a/v3/onesignal-metabox/onesignal-metabox.php b/v3/onesignal-metabox/onesignal-metabox.php
@@ -98,12 +98,22 @@ function onesignal_metabox($post)
 
 function onesignal_meta_files()
 {
-  wp_enqueue_script('onesignal_metabox_js', plugins_url('onesignal-metabox.js', __FILE__));
-  wp_enqueue_style('onesignal_metabox_css', plugins_url('onesignal-metabox.css', __FILE__), array(), time());
+  $cache_buster = ceil(time() / 3600); // updates every hour
+  wp_enqueue_script(
+    'onesignal_metabox_js',
+    plugins_url('onesignal-metabox.js', __FILE__),
+    array(),
+    $cache_buster,
+    true // load in the footer for performance
+  );
+  wp_enqueue_style(
+    'onesignal_metabox_css',
+    plugins_url('onesignal-metabox.css', __FILE__),
+    array(),
+    $cache_buster
+  );
 }
 
-
-
 // Store meta data
 add_action('save_post', 'onesignal_save_meta', 10);