Skip to content
This repository was archived by the owner on Mar 25, 2021. It is now read-only.

Wrapper for TempProbe #11

Merged

Conversation

cherbel
Copy link
Contributor

@cherbel cherbel commented Nov 2, 2020

Update: We have clean test runs.

This does not work due to the issue submitted here: Arduino-CI/arduino_ci#192

@jgfoster
Copy link
Member

jgfoster commented Nov 4, 2020

We are also waiting on Arduino-CI/arduino_ci#193.

@ianfixes
Copy link

I think the problem is elsewhere, see cherbel#1

@ianfixes
Copy link

It looks like you might be checking out the wrong branch in your install script:

# get custom version of Adafruit_MAX31865
git clone https://github.com/Arduino-CI/Adafruit_MAX31865.git
mv Adafruit_MAX31865 $(bundle exec arduino_library_location.rb)

The error you're getting about Adafruit_MAX31865_CI.h: No such file or directory makes sense because the Adafruit_MAX31865_CI.h file is located in the arduino_ci branch of Arduino-CI/Adafruit_MAX31865, and in the snippet above you're just cloning the master branch.

@jgfoster
Copy link
Member

See Arduino-CI/arduino_ci#212 for an example of what we are trying to do.

@ianfixes
Copy link

I just merged arduino_ci code that should fix this issue

@cherbel
Copy link
Contributor Author

cherbel commented Nov 24, 2020

@jgfoster I think this is ready to be merged.

@prestoncarman
Copy link
Member

If this is ready, please update the PR title and description.

Change to multi-line comment.
@jgfoster jgfoster changed the title Arduino TempProbe changes WIP Wrapper for TempProbe Nov 27, 2020
Copy link
Member

@prestoncarman prestoncarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgfoster jgfoster merged commit c41d181 into Open-Acidification:master Nov 27, 2020
@prestoncarman
Copy link
Member

@all-contributors please add @cherbel for code

@allcontributors
Copy link
Contributor

@prestoncarman

I've put up a pull request to add @cherbel! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants