Skip to content

Integration request to master#1211

Merged
dpasukhi merged 41 commits intomasterfrom
IR
Apr 30, 2026
Merged

Integration request to master#1211
dpasukhi merged 41 commits intomasterfrom
IR

Conversation

@dpasukhi
Copy link
Copy Markdown
Member

Integration request to collect a sequence of patches as a periodical branch.
Will be available for short time only during development circle.

dpasukhi and others added 2 commits April 7, 2026 18:14
Add tests for TopExp_Explorer nested iteration and reinitialization
Units_Measurement now prints name of unknown unit if conversion failed.
Units::Convert() now prints name of unknown unit if conversion failed.
Units::Convert() no longer crashes when first unit is unknown.
Updated incorrect descriptions of methods UnitsAPI - non-existing unit type "millimeter" is replaced with "mm".
@dpasukhi dpasukhi added the 2. IR Integration request (Used for marking PR as a collection of multiple integration for master) label Apr 19, 2026
@github-actions
Copy link
Copy Markdown

Performance Test Summary

Commit: 3a1543757d7333bba62115403db25c3b702e6236

Title: Merge 7289db9 into 0ebbbed

Platform: macos-x64

Total MEMORY difference: 361115 / 369740 [-2.33%]
Total CPU difference: 4.660000000000001 / 4.540000000000003 [+2.64%]
Total IMAGE difference: 0 / 0

Platform: windows-x64

Total MEMORY difference: 93365918 / 93343109 [+0.02%]
Total CPU difference: 3541.640625 / 3532.484375 [+0.26%]
Total IMAGE difference: 14 / 14265 [0.10%]

Platform: linux-clang-x64

Total MEMORY difference: 84394517 / 84462468 [-0.08%]
Total CPU difference: 2959.0000000000973 / 3002.980000000098 [-1.46%]
Total IMAGE difference: 15 / 14143 [0.11%]

Move Windows ARM64 validation from IR to master
…ul (#1212)

- Migrate NCollection map/sequence/array size APIs from int to size_t; Size() returns size_t, Length() remains the int accessor; int overloads delegate through NbBucketsFromInt() with a negative-input guard.
- Add NCollection_LinearVector: contiguous flat-buffer dynamic array with Standard::Reallocate-based growth for trivial types and move-construction for non-trivial types.
- Rewrite NCollection_DynamicArray on top of LinearVector<T*>; switch to power-of-two block sizing with precomputed shift/mask.
- Rework NCollection_BaseMap iterator with a forward findFirst() helper (no negative-bucket arithmetic); unify ReSize/BeginResize/EndResize on size_t.
- Enable thread-safe fast path in NCollection_IncAllocator via std::shared_mutex + CAS bump allocation on atomic AvailableSize; exclusive lock is taken only for new-block allocation and list reordering.
- Remove NCollection_BasePointerVector (superseded by NCollection_LinearVector).
- Remove NCollection_BaseMap::Statistics (unused).
- Add <cstddef> include in NCollection_Primes.hxx so size_t resolves on clean builds.
- Document iterator invalidation contract on NCollection_LinearVector.
- Unify BRepGraph programmatic mutation behind EditorView: delete BuilderView (2648+552 lines); EditorView (3186+930 lines) and EditorView_Mut.cxx own both structural creation (Add*/Remove*) and field-level RAII-scoped mutation (Mut*()) with automatic OwnGen and SubtreeGen propagation.
- Add BRepGraph_MeshCache and BRepGraph_MeshView: two-tier mesh storage separating algorithm-derived caches from persistent (definition) triangulations; freshness is keyed on FaceDef.OwnGen; cache writes do not mutate the model.
- Document the MeshCache invalidation contract in BRepGraph_MeshCache.hxx (which mutations bump Face.OwnGen and how markRepModified closes the loop for Surface/Triangulation reps).
- Add BRepGraph_RefsIterator (generic flat ref scan with RefTraits dispatch) and BRepGraph_ReverseIterator (typed parent-traversal wrappers over reverse-index vectors).
- Rework RefId entity model: replace inline refs with typed RefId vectors; add OccurrenceRef and Kind::Occurrence=7; BRepGraphInc_WireExplorer now requires a VertexRefLookup.
- Rename layers for consistency: BRepGraph_ParamLayer to BRepGraph_LayerParam, BRepGraph_RegularityLayer to BRepGraph_LayerRegularity; rename BRepGraphInc_Usage to BRepGraphInc_Instance.
- Replace RootNodeIds() with RootProductIds() returning product roots only.
- Update BRepGraph and BRepGraphInc READMEs; fix stale RootNodeIds reference.
- Sweep Size() to Length() renames across ~200 callers in TKG2d, TKG3d, TKMath, TKMesh, TKBO, TKOffset, TKShHealing, TKTopAlgo, TKBRep, TKService, TKV3d, TKOpenGl, TKMeshVS, TKDE*, TKXCAF, TKXSBase, TKLCAF, TKStd, and Draw harness.
- Add GTest coverage for new containers and the BRepGraph overhaul: NCollection_DynamicArray_Test, NCollection_LinearVector_Test, BRepGraph_Fuzz_Test, BRepGraph_Iterator_Test, BRepGraph_LayerIterator_Test, BRepGraph_MeshCache_Test, BRepGraph_MutGuard_Test, BRepGraph_ReplaceVertex_Test, BRepGraph_ReverseIterator_Test, BRepGraph_ScenarioMatrix_Test, BRepGraph_TypedIdDispatch_Test, BRepGraph_WireExplorer_Test.
@github-actions
Copy link
Copy Markdown

Performance Test Summary

Commit: dcbf3858cbff84d7801f6f230f8df65f065b984e

Title: Merge b3ccf20 into 0ebbbed

Platform: macos-x64

Total MEMORY difference: 364696 / 369740 [-1.36%]
Total CPU difference: 4.89 / 4.540000000000003 [+7.71%]
Total IMAGE difference: 0 / 0

Platform: windows-x64

Total MEMORY difference: 93389326 / 93346512 [+0.05%]
Total CPU difference: 3521.859375 / 3535.765625 [-0.39%]
Total IMAGE difference: 20 / 14265 [0.14%]

Platform: linux-clang-x64

Total MEMORY difference: 84357602 / 84463398 [-0.13%]
Total CPU difference: 2931.6400000001095 / 3003.050000000098 [-2.38%]
Total IMAGE difference: 16 / 14144 [0.11%]

@github-actions
Copy link
Copy Markdown

Performance Test Summary

Commit: 341e07d91a419200f34c212cd849f1a9f813e023

Title: Merge 0755b6f into 0ebbbed

Platform: macos-x64

Total MEMORY difference: 369922 / 369740 [+0.05%]
Total CPU difference: 4.490000000000004 / 4.540000000000003 [-1.10%]
Total IMAGE difference: 0 / 0

Platform: windows-x64

Total MEMORY difference: 93407306 / 93346512 [+0.07%]
Total CPU difference: 3589.609375 / 3535.765625 [+1.52%]
Total IMAGE difference: 21 / 14265 [0.15%]

Platform: linux-clang-x64

Total MEMORY difference: 84424721 / 84464012 [-0.05%]
Total CPU difference: 3033.160000000077 / 3003.070000000098 [+1.00%]
Total IMAGE difference: 14 / 14144 [0.10%]

- Add null-checks around `SDR->Definition().PropertyDefinition()` before extracting `ProductDefinition()` (both for `rep1`/`pd1` and `rep2`/`pd2`).
@github-actions
Copy link
Copy Markdown

Performance Test Summary

Commit: cf664ea283433fd416003dd042fbe872cb5756c1

Title: Merge 2f3554f into 0ebbbed

Platform: macos-x64

Total MEMORY difference: 361713 / 366816 [-1.39%]
Total CPU difference: 7.459999999999998 / 5.6299999999999955 [+32.50%]
Total IMAGE difference: 0 / 0

Platform: windows-x64

Total MEMORY difference: 93445267 / 93346121 [+0.11%]
Total CPU difference: 3525.140625 / 3542.609375 [-0.49%]
Total IMAGE difference: 19 / 14264 [0.13%]

Platform: linux-clang-x64

Total MEMORY difference: 84437426 / 84443090 [-0.01%]
Total CPU difference: 2918.3200000000884 / 3014.4200000000887 [-3.19%]
Total IMAGE difference: 13 / 14143 [0.09%]

- Allow `TransferRoots()` and `TransferList()` to append null `TopoDS_Shape` results (matching `TransferEntity()` behavior).
- Update `OneShape()` to skip null shapes when building the result compound to avoid a crash.
- Refactor transfer loops / locals (naming, progress scope sizing, `size_t` iteration).
@github-actions
Copy link
Copy Markdown

Performance Test Summary

Commit: 76c4daa5191a79e80bd1324141c6db41ed0a6150

Title: Merge 75d90ef into 0ebbbed

Platform: macos-x64

Total MEMORY difference: 365892 / 366816 [-0.25%]
Total CPU difference: 5.689999999999992 / 5.6299999999999955 [+1.07%]
Total IMAGE difference: 0 / 0

Platform: windows-x64

Total MEMORY difference: 93418221 / 93345430 [+0.08%]
Total CPU difference: 3514.5625 / 3542.609375 [-0.79%]
Total IMAGE difference: 16 / 14264 [0.11%]

Platform: linux-clang-x64

Total MEMORY difference: 84417991 / 84441989 [-0.03%]
Total CPU difference: 2949.8000000001 / 3014.3900000000885 [-2.14%]
Total IMAGE difference: 12 / 14143 [0.08%]

- Extend STEPCAF dimension value conversion to recognize `StepRepr_ReprItemAndLengthMeasureWithUnitAndQRI` and `StepRepr_ReprItemAndPlaneAngleMeasureWithUnitAndQRI`.
- Extend regression test `bug33095` to validate scaling of the nominal dimension value between `m` and `mm`.
…1219)

Selection was broken for presentations that used Graphic3d_Group::SetFlippingOptions
(AIS_TextLabel, PrsDim_Dimension): OpenGl_Flipper mirrors the geometry at draw time
to keep labels upright relative to the camera, but the selection pipeline computed
BVH boxes and sensitive frustums in the unflipped local coordinates. When the camera
was rotated past the flipping threshold, clicks on the on-screen label missed.

- Add Graphic3d_Flipper: a CPU-side analogue of OpenGl_Flipper carrying the reference
  plane and templated Compute()/Apply() that reproduces the render-time flip matrix.
  Each flip branch is a 180 deg rotation (involution), so the matrix is self-inverse.
- Extend Graphic3d_CStructure with HasGroupFlipping()/SetGroupFlipping() alongside
  the existing transform-persistence flag; reset it in Graphic3d_Structure::clear().
- Add Graphic3d_Group::Flipper() and a myFlipper member populated from
  OpenGl_Group::SetFlippingOptions(true,...). The render-side OpenGl_Flipper element
  is still emitted for the push/pop bracket; myFlipper persists across the matching
  SetFlippingOptions(false,...) call so the selection side can see that the group
  contains flipped geometry.
- Add Select3D_SensitiveEntity::Flipper() / SetFlippingOptions() so sensitive
  entities can carry the same flipping metadata used by the selection traversal;
  include the handle in DumpJson.
- SelectMgr_SensitiveEntitySet tracks myNbEntityWithFlipping in Append()/Remove();
  HasEntityWithFlipping() exposes it to the viewer selector.
- SelectMgr_SelectableObjectSet::appropriateSubset() routes presentations with
  HasGroupFlipping() to the 3d-persistent BVH subset (same as transform persistence).
- BVHBuilderAdaptorPersistent merges the flipping and transform-persistence loops
  into a single pass: for each group with a Flipper or TransformPersistence, build
  its local bbox, apply the flip (if any), then apply the TransformPersistence
  (if any), then add the resulting box to the object bbox; object-level
  TransformPersistence is applied once to the merged box. Note: for the rare case
  of object-level + group-level TransformPersistence the application order differs
  from the prior code (object-TP now runs after group-TP contributions are added).
  Common cases (only one or the other) are behavior-preserving.
- SelectMgr_ViewerSelector::traverseObject() bypasses the root/per-node overlap
  early-outs when the entity set contains flipped sensitives, and folds the flip
  matrix into aInvFlippingAndPers = T_flip * aInvSensTrsf before computeFrustum()
  and checkOverlap(). Using T_flip directly is valid because it is self-inverse.
  Before Compute(), the object's Transformation() is folded into aMVForFlip via
  Graphic3d_TransformUtils::Convert<double> so the isReversedX/Y/Z decision
  agrees with OpenGl_Flipper::Render() which uses WorldView * ModelWorld.
- SelectMgr_SelectableObjectSet::BVHBuilderAdaptorPersistent computes the same
  aMVForFlip once per object (hoisted outside the group loop) and passes it to
  Graphic3d_Flipper::Apply, so BVH bounds and per-sensitive overlap testing use
  the same flip matrix.
- SelectMgr::ComputeSensitivePrs() forwards the flipper to the debug presentation's
  current group so selection-mode visualization reflects the flip.

Known limitation (narrowed): the selection pipeline now folds the object's
Transformation() into the MV passed to Graphic3d_Flipper::Compute, covering the
common case of a flipping label on a rotated assembly. Group-level
Graphic3d_Group::Transformation() is still not folded in on the selection side
because the sensitive entity does not carry a reference to its host group; this
only affects consumers that give the flipping group its own non-identity gp_Trsf
(uncommon in stock OCCT). A TODO in Graphic3d_Flipper::Compute and
SelectMgr_ViewerSelector marks the deferred follow-up.
@github-actions
Copy link
Copy Markdown

Performance Test Summary

Commit: 1812d4de2c14a3d9401e929c969f4865707553a3

Title: Merge d75806d into 0ebbbed

Platform: linux-clang-x64

Total MEMORY difference: 84428901 / 84445289 [-0.02%]
Total CPU difference: 2959.8499999998476 / 3014.519999999871 [-1.81%]
Total IMAGE difference: 14 / 14144 [0.10%]

Platform: windows-x64

Total MEMORY difference: 93420240 / 93342779 [+0.08%]
Total CPU difference: 3503.234375 / 3539.09375 [-1.01%]
Total IMAGE difference: 20 / 14264 [0.14%]

Platform: macos-x64

Total MEMORY difference: 369726 / 366816 [+0.79%]
Total CPU difference: 6.299999999999991 / 5.629999999999997 [+11.90%]
Total IMAGE difference: 0 / 0

@github-actions
Copy link
Copy Markdown

Performance Test Summary

Commit: b5657d7e2f13dc2d78b00c485a9213d4847c6aa7

Title: Merge 98ca3a5 into 0ebbbed

Platform: macos-x64

Total MEMORY difference: 352824 / 366816 [-3.81%]
Total CPU difference: 6.589999999999991 / 5.6299999999999955 [+17.05%]
Total IMAGE difference: 0 / 0

Platform: windows-x64

Total MEMORY difference: 93428285 / 93346505 [+0.09%]
Total CPU difference: 3559.609375 / 3542.640625 [+0.48%]
Total IMAGE difference: 16 / 14265 [0.11%]

Platform: linux-clang-x64

Total MEMORY difference: 84440432 / 84443203 [-0.00%]
Total CPU difference: 2990.5400000000973 / 3014.4300000000885 [-0.79%]
Total IMAGE difference: 15 / 14143 [0.11%]

Swap the last two vertex indices in the second triangle of each color-scale
rectangle so the two triangles share the same diagonal with consistent CCW
orientation. Earlier indexing (v+1, v+2, v+3) built two overlapping triangles
with opposite winding, producing visible seams and dropped vertices under
back-face culling.
@github-actions
Copy link
Copy Markdown

Performance Test Summary

Commit: 127c617aaa745185448a7c5d7291af90e7f9c8ab

Title: Merge dc357cf into 0ebbbed

Platform: macos-x64

Total MEMORY difference: 358536 / 366816 [-2.26%]
Total CPU difference: 4.610000000000002 / 5.6299999999999955 [-18.12%]
Total IMAGE difference: 0 / 0

Platform: windows-x64

Total MEMORY difference: 93424822 / 93343470 [+0.09%]
Total CPU difference: 3485.703125 / 3539.09375 [-1.51%]
Total IMAGE difference: 18 / 14264 [0.13%]

Platform: linux-clang-x64

Total MEMORY difference: 84445482 / 84443749 [+0.00%]
Total CPU difference: 2967.9100000000963 / 3014.4400000000887 [-1.54%]
Total IMAGE difference: 16 / 14143 [0.11%]

…Array (#1221)

Returns the three vertex positions of the triangle at the given index as a
std::array<NCollection_Vec3<float>, 3>. Downstream selection consumers can
now query the triangulation geometry of a picked primitive array without
re-walking the underlying Graphic3d_Buffer/Graphic3d_IndexBuffer.

Uses the existing file-local getTriIndices helper and the private getPosVec3
member, so the implementation is a pure accessor. Returning std::array keeps
the contract explicit (always three vertices, no heap allocation)
@github-actions
Copy link
Copy Markdown

Performance Test Summary

Commit: fa1582f8de4678e429a2ea25bb9428c323b19bf0

Title: Merge 0ad69de into 0ebbbed

Platform: linux-clang-x64

Total MEMORY difference: 84448706 / 84443758 [+0.01%]
Total CPU difference: 2969.7999999998624 / 3014.449999999871 [-1.48%]
Total IMAGE difference: 12 / 14143 [0.08%]

Platform: windows-x64

Total MEMORY difference: 93415013 / 93342050 [+0.08%]
Total CPU difference: 3574.6875 / 3539.078125 [+1.01%]
Total IMAGE difference: 19 / 14264 [0.13%]

Platform: macos-x64

Total MEMORY difference: 364963 / 366816 [-0.51%]
Total CPU difference: 5.279999999999993 / 5.629999999999997 [-6.22%]
Total IMAGE difference: 0 / 0

…lyline check (#1222)

Replaces two buggy pieces of SelectMgr_TriangularFrustumSet used during
polyline (polygon rubber-band) selection:

- OverlapsBox(min, max, bool* theInside): the corner-edge isIntersectBoundary
  heuristic produced false "fully inside" answers whenever an AABB was large
  enough that its 12 edges did not cross the polyline but its interior did
  not lie inside either. Rewrite: first probe every frustum for any overlap;
  if none, return false. Otherwise, project the 8 AABB corners onto the
  frustum near plane and apply a ray-cast inside test against the original
  polyline loop. If any corner projects outside, clear theInside; else leave
  it untouched. The near-plane coplanarity assumption is guaranteed by
  Build(), which derives every near vertex from
  myBuilder->ProjectPntOnViewPlane(x, y, 0.0).

- OverlapsPoint(const gp_Pnt&): previously a stub returning false, which made
  strict-inclusion polyline selection of Select3D_SensitiveTriangle,
  SensitivePoly, SensitiveTriangulation, SensitivePrimitiveArray,
  MeshVS_CommonSensitiveEntity and MeshVS_SensitiveQuad silently impossible
  (those sensitive types call theMgr.OverlapsPoint(...) on each vertex in
  strict-inclusion mode; a blanket false meant nothing was ever picked). Now
  delegates to the same near-plane projection + ray-cast test, so strict
  inclusion works for all these sensitive types in polyline mode.

Covered by a new Draw test tests/vselect/bugs/bug_polyline_inclusion that
exercises both strict-inclusion and overlap modes for spheres inside/outside
a polygonal rubber band. No GTest is added because constructing a working
TriangularFrustumSet requires a configured Graphic3d_Camera + viewport; the
Tcl test is the regression gate.
@github-actions
Copy link
Copy Markdown

Performance Test Summary

Commit: e6e058cbe7c85acce151d34d2a5aa69dd59eabed

Title: Merge c076c4e into 0ebbbed

Platform: macos-x64

Total MEMORY difference: 354066 / 366816 [-3.48%]
Total CPU difference: 4.490000000000004 / 5.6299999999999955 [-20.25%]
Total IMAGE difference: 0 / 0

Platform: windows-x64

Total MEMORY difference: 93427574 / 93344545 [+0.09%]
Total CPU difference: 3503.734375 / 3539.125 [-1.00%]
Total IMAGE difference: 13 / 14265 [0.09%]

Platform: linux-clang-x64

Total MEMORY difference: 84439261 / 84441989 [-0.00%]
Total CPU difference: 2937.0400000000886 / 3014.3900000000885 [-2.57%]
Total IMAGE difference: 11 / 14143 [0.08%]

- Refactors `IsSameOriented()` to iterate over face edges and select one that is present in the shell’s edge→faces map.
- Adds a guard (`Contains`) before `FindFromKey()` to prevent invalid map access.
- Updates local naming (`theFace`, `theShell`, `anEdgeFaceMap`) to match common OCCT parameter naming style.
@github-actions
Copy link
Copy Markdown

Performance Test Summary

Commit: 4ba0310f9e78711a89046dfee05dc63b2a3fcc70

Title: Merge 9d49812 into 0ebbbed

Platform: linux-clang-x64

Total MEMORY difference: 84447435 / 84441406 [+0.01%]
Total CPU difference: 2958.1799999998398 / 3014.379999999871 [-1.86%]
Total IMAGE difference: 14 / 14143 [0.10%]

Platform: windows-x64

Total MEMORY difference: 93499757 / 93342779 [+0.17%]
Total CPU difference: 3526.046875 / 3539.09375 [-0.37%]
Total IMAGE difference: 16 / 14264 [0.11%]

Platform: macos-x64

Total MEMORY difference: 360508 / 366816 [-1.72%]
Total CPU difference: 5.789999999999992 / 5.629999999999997 [+2.84%]
Total IMAGE difference: 0 / 0

Complete the AIS_ColorScale rectangle winding fix by following the
upstream patch revision from Kirill Gavrilov <kirill@sview.ru>,
commit 9b8c624.

Switch the rectangle helper from manual triangle edges to
Graphic3d_ArrayOfPrimitives::AddQuadTriangleEdges() while preserving
the top/bottom color layout. This keeps the quad in a consistent CCW
orientation and avoids visible seam edge or front-face loss when BACK
face culling is enabled.

Add DRAW regression test tests/v3d/colorscale/colorscale_faceculling
using the original reproduction scenario and a pixel check for the
front face.
@github-actions
Copy link
Copy Markdown

Performance Test Summary

Commit: 57cb528a319b8c021b0fa1fc8ab7b7961e66c3b7

Title: Merge b1646d7 into 0ebbbed

Platform: macos-x64

Total MEMORY difference: 369531 / 366816 [+0.74%]
Total CPU difference: 5.419999999999995 / 5.6299999999999955 [-3.73%]
Total IMAGE difference: 0 / 0

Platform: windows-x64

Total MEMORY difference: 93412840 / 93346159 [+0.07%]
Total CPU difference: 3550.296875 / 3542.625 [+0.22%]
Total IMAGE difference: 16 / 14264 [0.11%]

Platform: linux-clang-x64

Total MEMORY difference: 84445967 / 84441820 [+0.00%]
Total CPU difference: 2932.0500000000925 / 3014.4100000000885 [-2.73%]
Total IMAGE difference: 13 / 14144 [0.09%]

dpasukhi and others added 2 commits April 23, 2026 11:35
The classical V3d_RectangularGrid / V3d_CircularGrid path generated all grid
lines on the CPU into a Graphic3d_Structure and recomputed them whenever any
parameter, the camera, or the privileged plane moved. Dense grids paid an
O(NxM) vertex rebuild per interaction and were effectively capped in extent;
there was no way to draw an infinite grid, a background (sky-plane) grid, or
a grid with sub-pixel line antialiasing.

This change promotes a shader-based grid to the single rendering path for
both rectangular and circular grids. Classical API, snap math and the vgrid
Draw command are preserved; only the presentation pipeline moves under the
shader.

Aspect layer:

- Add Aspect_GridParams: POD carrying shader-only appearance knobs (color,
  origin, Scale, ScaleY, LineThickness, RotationAngle, AngularDivisions,
  IsBackground, IsDrawAxis, IsInfinity, DrawMode, SizeX/SizeY, Radius,
  AngleStart/AngleEnd). EffectiveScaleY() returns ScaleY when non-zero and
  Scale() otherwise; IsCircular() is shorthand for AngularDivisions() > 0;
  IsBounded() / IsArc() report active clipping.
- Extend Aspect_RectangularGrid with SizeX/SizeY/ZOffset fields and
  accessors; extend Aspect_CircularGrid with Radius/ZOffset/AngleStart/
  AngleEnd and IsArc(). Snap math is unchanged.
- Add Graphic3d_CView::GridDisplay(Aspect_GridParams, gp_Ax3) and GridErase()
  virtuals with no-op defaults; include Aspect_GridParams.hxx and gp_Ax3.hxx
  from Graphic3d_CView.hxx.

Shader (Graphic3d_ShaderManager::getGridProgram):

- Full-screen triangle unprojected per-fragment to world-space Near/Far
  points, ray-plane intersection against an arbitrary plane supplied through
  uPlaneOrigin / uPlaneX / uPlaneY / uPlaneN uniforms. Per-fragment unproject
  avoids perspective-divide nonlinearity that plagues varying-based rays.
- Helper intersectPlane() uses a normalized direction for the parallel test,
  so GRID_PARALLEL_EPS = 1e-6 is a dimensionless |sin(angle)| threshold
  (~5.7e-5 deg) that stays scale-invariant under any world-depth range.
- gridLines2d / gridLines1d: fwidth-based AA plus per-axis Nyquist fade
  (smoothstep(1.0, 2.0, fwidth)). Once a grid period fits inside a single
  pixel, that axis fades to zero instead of smearing into a bright haze at
  grazing angles. Lines mode uses max() of per-axis alphas; points mode
  uses the product so only intersections light up.
- Bounded work area (rectangular SizeX/SizeY, circular Radius, optional arc
  range): hard discard and smoothstep endpoint are both extended by
  fwidth(coord), giving a single-screen-pixel AA transition instead of a
  binary staircase at the clipping edge.
- Stable-reference rebasing for the rectangular grid: CPU unprojects the
  screen center to the plane every frame and uploads the plane-local hit as
  uStableRefLocal + uHasStableRef. The shader subtracts
  floor(ref * scale) / scale before fract(), keeping the fract() argument
  bounded at far world offsets without changing the visible line pattern.
- Branch on uGridType (0 = rectangular, 1 = circular). Circular path uses
  polar coords (length, atan2) scaled by uScaleX and uAngularScale;
  plane-local X/Y axis colouring is applied uniformly in both modes so the
  red/green/blue cardinal lines stay straight.
- uDrawMode switches lines vs points (Aspect_GDM_Points); uIsBackground
  pins gl_FragDepth to 1.0 - 1e-5 for the sky-plane look. Explicit GL 3.2 /
  GLES 3.0 version headers; requires gl_VertexID and gl_FragDepth.

OpenGL plumbing:

- Add OpenGl_ShaderManager::BindGridProgram(): lazy Create + cache, routed
  through bindProgramWithState so the standard OCCT matrix uniforms
  (occProjectionMatrix, occWorldViewMatrix, occModelWorldMatrix and their
  inverses, occViewport) are pushed onto the grid program every bind.
  myGridProgram is nullified in clear() so context resets release the
  compiled program.
- Add OpenGl_View::GridDisplay / GridErase overrides and private
  renderGrid(). The renderer binds a dedicated VAO (core-profile safe) and
  saves/restores program, depth test / func / mask, blend enable,
  blend-func-separate, and depth-clamp. ProjectionState / WorldViewState are
  push/pop-guarded. Original ZNear/ZFar/ProjType are captured before any
  mutation so a mid-function ZFitAll cannot clobber user-set vzrange on
  restore.
- Background-mode pan/rotate compensation is derived from the view-matrix
  delta (currentView * refView^-1) captured at GridDisplay(); no public
  Graphic3d_Camera API change is needed.
- Compute the plane-local stable reference in renderGrid via
  Graphic3d_TransformUtils::UnProject on the viewport center; upload
  uStableRefLocal / uHasStableRef alongside the other uniforms.
- Insert renderGrid() between renderScene() and renderTrihedron() in the
  non-immediate draw pass; release myGridVao in ReleaseGlResources.

V3d layer:

- Add V3d_View::GridDisplay(params) / GridDisplay(params, plane) / GridErase
  as thin pass-throughs; the single-argument overload uses
  V3d_Viewer::PrivilegedPlane().
- Rewrite V3d_RectangularGrid and V3d_CircularGrid: drop the nested
  RectangularGridStructure / CircularGridStructure classes, myGroup,
  DefineLines, DefinePoints, and all myCur* caching flags. Display() /
  Erase() / UpdateDisplay() now call syncViews() which builds an
  Aspect_GridParams from the Aspect_{Rectangular,Circular}Grid state
  (XStep/YStep -> Scale/ScaleY, RadiusStep -> Scale, DivisionNumber ->
  AngularDivisions, XOrigin/YOrigin/OffSet -> Origin, RotationAngle ->
  RotationAngle, SizeX/SizeY/Radius/ArcRange -> bounds, DrawMode)
  and broadcasts it over V3d_Viewer::DefinedViews(). Snap math in
  Aspect_RectangularGrid / Aspect_CircularGrid is untouched.
- V3d_RectangularGrid is unbounded by default (SizeX = SizeY = 0). The grid
  renderer honours an explicit SetSizeX / SetSizeY to activate in-shader
  clipping with AA edges; applications that want the old bounded behaviour
  set the size explicitly.

Draw / tests:

- vgrid Draw command gains -type {rect|circ|inf|infinite}, -color R G B,
  -scale N, -lineThickness T, -background {0|1}, -drawAxis {0|1},
  -inf {0|1}. Existing -origin, -step, -rotAngle, -zoffset, -size, -radius,
  -mode flags are retained and now drive the shader path.
- tests/v3d/grid/ (new group) adds ortho, persp, inf_pan, inf_rotate,
  inf_plane, rect_shader, circ_shader, rect_points, inf_options,
  bounded_rect, bounded_circ Draw regressions covering background mode,
  matrix-derived pan/rotate stability, non-XY privileged planes,
  anisotropic rectangular cells, polar divisions, points draw mode, and
  in-shader bounded clipping. Registered in tests/v3d/grids.list.
- Add src/Visualization/TKService/GTests/Aspect_GridParams_Test.cxx covering
  defaults, round-trip, copy, EffectiveScaleY fallback, RotationAngle
  round-trip, AngularDivisions / IsCircular toggle, and DrawMode round-trip.
- Add src/Visualization/TKService/GTests/Aspect_Grid_Bounds_Test.cxx
  covering SizeX/SizeY/Radius/ArcRange on the base grid classes.

Behaviour notes:

- V3d_RectangularGrid and V3d_CircularGrid no longer rely on
  Graphic3d_Structure view affinity, so new views added to the viewer after
  V3d_Viewer::ActivateGrid() must trigger a re-broadcast (call
  Grid()->Display() on the viewer or re-activate) to pick up the grid.
- Aspect_GDM_Points is now rendered as dots at grid intersections through
  uDrawMode (not as the old CPU point markers). Applications that depended
  on point markers as selectable entities should present them through a
  dedicated AIS object.
- V3d_RectangularGrid is unbounded by default; the old behaviour of
  capping to 0.5 * DefaultViewSize() is available via an explicit
  SetSizeX / SetSizeY call.
- Aspect_GridParams::Origin is a plane-local offset; the plane itself is
  supplied as a gp_Ax3 (defaults to V3d_Viewer::PrivilegedPlane()).
- Adds a 3D-distance based closure check that marks the intersection line as closed when the walker returns near the starting point.
- Forces early termination and closes the polyline by re-adding the first point when 3D cycling is detected.
- Replace `BRepGraph_Builder::Perform()` with `BRepGraph_Builder::Add()` and introduce `BRepGraph::Clear()` as the rebuild boundary.
- Refactor product/occurrence editing APIs (e.g., `AddAssembly` → `CreateEmptyProduct`, `AddOccurrence` → `LinkProducts`, occurrence mutation via `Editor().Occurrences()`).
- Update a large set of GTests and inline docs to use the new lifecycle and API names.
@github-actions
Copy link
Copy Markdown

Performance Test Summary

Commit: 4d48fe9146605c751643797bbfdea31416d1bc38

Title: Merge 048a292 into 0ebbbed

Platform: macos-x64

Total MEMORY difference: 361398 / 366816 [-1.48%]
Total CPU difference: 4.909999999999999 / 5.6299999999999955 [-12.79%]
Total IMAGE difference: 0 / 0

Platform: windows-x64

Total MEMORY difference: 93172944 / 93137102 [+0.04%]
Total CPU difference: 3492.375 / 3500.90625 [-0.24%]
Total IMAGE difference: 39 / 14254 [0.27%]

Platform: linux-clang-x64

Total MEMORY difference: 84156840 / 84262057 [-0.12%]
Total CPU difference: 2949.7900000000905 / 2983.070000000073 [-1.12%]
Total IMAGE difference: 41 / 14134 [0.29%]

2 cylinders are tangent along a line.
The analytical intersection returns a point which is not valid and it is a restriction of the analytical intersection algorithm.
The patch is ensured to use the implicit-implicit intersection algorithm.
Refactor FillSameDomainFaces to use parent solid instead of shell for Same-Domain face mapping
@github-actions
Copy link
Copy Markdown

Performance Test Summary

Commit: 1ffd9d2f19df652d9fa92ee9f9de46bd314283ae

Title: Merge bea50c2 into 0ebbbed

Platform: linux-clang-x64

Total MEMORY difference: 84168271 / 84260882 [-0.11%]
Total CPU difference: 2925.1199999998566 / 2983.0399999998403 [-1.94%]
Total IMAGE difference: 37 / 14134 [0.26%]

Platform: windows-x64

Total MEMORY difference: 93159469 / 93138522 [+0.02%]
Total CPU difference: 3456.21875 / 3500.921875 [-1.28%]
Total IMAGE difference: 36 / 14254 [0.25%]

Platform: macos-x64

Total MEMORY difference: 372125 / 366816 [+1.45%]
Total CPU difference: 6.5399999999999885 / 5.629999999999997 [+16.16%]
Total IMAGE difference: 0 / 0

…g with shared sub-shapes (#1227)

- Add replacement-chain leaf resolution (`ValueLeaf()`), cycle rejection on `Replace()`, and DFS in-flight guards to prevent recursive descent loops.
- Update ShapeFix healing routines to avoid repeated sub-shape re-expansion, add progress cancellation checkpoints, and reduce quadratic wire-fixing cost.
- Add/adjust regression coverage (new GTests; updated existing Draw tests/baselines).
@github-actions
Copy link
Copy Markdown

Performance Test Summary

Commit: 0dcc7ff668ac64911eb306282b1e59fd167df43d

Title: Merge 3cf18a1 into 0ebbbed

Platform: macos-x64

Total MEMORY difference: 369465 / 366816 [+0.72%]
Total CPU difference: 5.009999999999999 / 5.6299999999999955 [-11.01%]
Total IMAGE difference: 0 / 0

Platform: windows-x64

Total MEMORY difference: 93156235 / 93137102 [+0.02%]
Total CPU difference: 3450.828125 / 3500.90625 [-1.43%]
Total IMAGE difference: 43 / 14254 [0.30%]

Platform: linux-clang-x64

Total MEMORY difference: 83590653 / 84260251 [-0.79%]
Total CPU difference: 2892.4800000001073 / 2983.010000000073 [-3.03%]
Total IMAGE difference: 38 / 14134 [0.27%]

@github-actions
Copy link
Copy Markdown

Performance Test Summary

Commit: deb65e6c3b8784579f0f68019d64608bbf99bf5d

Title: Merge aaa82fc into 0ebbbed

Platform: linux-clang-x64

Total MEMORY difference: 83580843 / 84262413 [-0.81%]
Total CPU difference: 2962.5799999998535 / 2983.10999999984 [-0.69%]
Total IMAGE difference: 38 / 14135 [0.27%]

Platform: windows-x64

Total MEMORY difference: 93211855 / 93140098 [+0.08%]
Total CPU difference: 3464.546875 / 3504.40625 [-1.14%]
Total IMAGE difference: 44 / 14253 [0.31%]

Platform: macos-x64

Total MEMORY difference: 365428 / 366816 [-0.38%]
Total CPU difference: 6.12999999999999 / 5.629999999999997 [+8.88%]
Total IMAGE difference: 0 / 0

- Added `Standard_DEPRECATED_STD(...)` to `Standard_Macro.hxx`, expanding to the standard `[[deprecated("...")]]` attribute (or empty when `OCCT_NO_DEPRECATED` is defined).
- Replaced `Standard_DEPRECATED(...)` with `Standard_DEPRECATED_STD(...)` in multiple `GCE2d_*` alias headers to keep deprecation warnings while restoring compiler compatibility.
@github-actions
Copy link
Copy Markdown

Performance Test Summary

Commit: e89e8bdec8f965838c6f224eb50bfe62d57ea237

Title: Merge 051b124 into 0ebbbed

Platform: linux-clang-x64

Total MEMORY difference: 83569819 / 84259122 [-0.82%]
Total CPU difference: 2972.809999999845 / 2982.98999999984 [-0.34%]
Total IMAGE difference: 38 / 14134 [0.27%]

Platform: windows-x64

Total MEMORY difference: 93151595 / 93136027 [+0.02%]
Total CPU difference: 3576.921875 / 3500.875 [+2.17%]
Total IMAGE difference: 46 / 14253 [0.32%]

Platform: macos-x64

Total MEMORY difference: 361098 / 366816 [-1.56%]
Total CPU difference: 4.710000000000001 / 5.629999999999997 [-16.34%]
Total IMAGE difference: 0 / 0

- Added new GTests covering multiple historical regressions (intersection, projection, pipe shell, boolean ops, fillet, distances, gp transforms, string hashing).
- Registered new test sources in the relevant `GTests/FILES.cmake` lists.
- Removed legacy Tcl tests and removed the associated QADraw commands from `QABugs_*.cxx`.
@github-actions
Copy link
Copy Markdown

Performance Test Summary

Commit: 87ff85df68cf8a4076c87e687071567ec34f7e29

Title: Merge 39bbf2e into 0ebbbed

Platform: linux-clang-x64

Total MEMORY difference: 83460642 / 84155763 [-0.83%]
Total CPU difference: 2970.1199999998516 / 2981.0799999998403 [-0.37%]
Total IMAGE difference: 42 / 14130 [0.30%]

Platform: windows-x64

Total MEMORY difference: 93025051 / 93021479 [+0.00%]
Total CPU difference: 3549.25 / 3501.765625 [+1.36%]
Total IMAGE difference: 44 / 14249 [0.31%]

Platform: macos-x64

Total MEMORY difference: 353126 / 366816 [-3.73%]
Total CPU difference: 6.0599999999999925 / 5.629999999999997 [+7.64%]
Total IMAGE difference: 0 / 0

dpasukhi and others added 2 commits April 28, 2026 19:54
- Replaced many direct field writes in tests with `EditorView` typed setters and `GenOps::RemoveRef`, and updated mutation-gen tests to use `MarkDirty()`.
- Added incremental reverse-index bind/unbind helpers in `BRepGraphInc_ReverseIndex` and updated editor operations to maintain the reverse index without full rebuilds in many cases.
- Extended `BRepGraph_Copy`/`BRepGraph_Transform` to `CopyNode`/`TransformNode`, adding optional mesh-copy/transform support and new coverage tests.
- Replaces `push_back(T(...))` with `emplace_back(...)` where applicable.
- Replaces `size() == 0` / `size() != 0` checks with `empty()` / `!empty()`.
- Simplifies trivial constructors/destructors to `= default` and removes redundant `(void)` parameter lists.
@github-actions
Copy link
Copy Markdown

Performance Test Summary

Commit: 2cd1b82cb631f345ca3b8f61b7fe4b3c1326989b

Title: Merge 200d1d0 into 0ebbbed

Platform: macos-x64

Total MEMORY difference: 356079 / 366816 [-2.93%]
Total CPU difference: 5.989999999999991 / 5.6299999999999955 [+6.39%]
Total IMAGE difference: 0 / 0

Platform: windows-x64

Total MEMORY difference: 93075256 / 93019519 [+0.06%]
Total CPU difference: 3533.234375 / 3498.25 [+1.00%]
Total IMAGE difference: 45 / 14249 [0.32%]

Platform: linux-clang-x64

Total MEMORY difference: 83479987 / 84154232 [-0.80%]
Total CPU difference: 2901.530000000089 / 2981.0100000000716 [-2.67%]
Total IMAGE difference: 39 / 14129 [0.28%]

- Inject `-Werror` (plus select warning toggles) into the shared GitHub Action used for configuring Linux/macOS builds.
- Replace several `0` / `CopyFromParent`-style null constants with `nullptr` to satisfy `-Wzero-as-null-pointer-constant`.
- Add defensive bounds/clamps and initialization to avoid fixed-buffer overreads/memcpy/sort issues and uninitialized reads.
@github-actions
Copy link
Copy Markdown

Performance Test Summary

Commit: 86f64b82033dddd5ba2f93da1d2e2666bf70df6f

Title: Merge 4d64ddc into 0ebbbed

Platform: macos-x64

Total MEMORY difference: 376099 / 366816 [+2.53%]
Total CPU difference: 4.490000000000004 / 5.6299999999999955 [-20.25%]
Total IMAGE difference: 0 / 0

Platform: windows-x64

Total MEMORY difference: 93092971 / 93021095 [+0.08%]
Total CPU difference: 3607.078125 / 3501.734375 [+3.01%]
Total IMAGE difference: 40 / 14248 [0.28%]

Platform: linux-clang-x64

Total MEMORY difference: 84056466 / 84154156 [-0.12%]
Total CPU difference: 2935.72000000006 / 2981.0000000000714 [-1.52%]
Total IMAGE difference: 40 / 14129 [0.28%]

@github-actions
Copy link
Copy Markdown

Performance Test Summary

Commit: 59b60579dc3184b19385aaea15ce0fa1865f89bf

Title: Merge 9255ff6 into 0ebbbed

Platform: macos-x64

Total MEMORY difference: 365568 / 366816 [-0.34%]
Total CPU difference: 4.600000000000002 / 5.6299999999999955 [-18.29%]
Total IMAGE difference: 0 / 0

Platform: windows-x64

Total MEMORY difference: 93106508 / 93021095 [+0.09%]
Total CPU difference: 3572.828125 / 3501.734375 [+2.03%]
Total IMAGE difference: 1102 / 14248 [7.73%]

Platform: linux-clang-x64

Total MEMORY difference: 84055116 / 84153018 [-0.12%]
Total CPU difference: 2958.940000000079 / 2980.9700000000716 [-0.74%]
Total IMAGE difference: 40 / 14129 [0.28%]

- Replaced many `std::vector` usages with `NCollection_LinearVector`, updating call sites to use `Size()`, `Append()`, `EmplaceAppend()`, `Resize()`, `Reserve()`, `Clear()`, and `Data()`.
- Updated BVH array type plumbing to consistently use `NCollection_LinearVector`, simplifying conditional STL-vs-OCCT handling.
- Extended `NCollection_LinearVector` API (constructor with size+value, `Resize(size, value)`) and added new GTests for this behavior.
@github-actions
Copy link
Copy Markdown

Performance Test Summary

Commit: 478b89bfc1646b13df0e3d63c067dd40a78caf23

Title: Merge 2cafd4f into 0ebbbed

Platform: macos-x64

Total MEMORY difference: 355887 / 366816 [-2.98%]
Total CPU difference: 6.0299999999999905 / 5.6299999999999955 [+7.10%]
Total IMAGE difference: 0 / 0

Platform: windows-x64

Total MEMORY difference: 93081266 / 93018444 [+0.07%]
Total CPU difference: 3460.765625 / 3498.21875 [-1.07%]
Total IMAGE difference: 46 / 14248 [0.32%]

Platform: linux-clang-x64

Total MEMORY difference: 84070248 / 84156318 [-0.10%]
Total CPU difference: 2929.100000000074 / 2981.1000000000718 [-1.74%]
Total IMAGE difference: 44 / 14130 [0.31%]

Flags:
aChecks="modernize-deprecated-headers,modernize-redundant-void-arg,modernize-use-bool-literals,modernize-use-equals-default,modernize-use-equals-delete,modernize-use-nullptr,modernize-use-override,performance-avoid-endl,performance-move-constructor-init,readability-braces-around-statements,readability-delete-null-pointer,readability-redundant-control-flow,readability-redundant-declaration,readability-redundant-function-ptr-dereference,readability-redundant-member-init,readability-redundant-string-init,readability-static-accessed-through-instance"

clang-tidy version: 22.1.3
@github-actions
Copy link
Copy Markdown

Performance Test Summary

Commit: d84d1c2eb1e4e7a297034f5fdad46ff3627b59e1

Title: Merge 1db8025 into 0ebbbed

Platform: macos-x64

Total MEMORY difference: 367353 / 366816 [+0.15%]
Total CPU difference: 4.550000000000003 / 5.6299999999999955 [-19.18%]
Total IMAGE difference: 0 / 0

Platform: windows-x64

Total MEMORY difference: 93200915 / 93022170 [+0.19%]
Total CPU difference: 3509.875 / 3501.765625 [+0.23%]
Total IMAGE difference: 1105 / 14249 [7.75%]

Platform: linux-clang-x64

Total MEMORY difference: 84054847 / 84155953 [-0.12%]
Total CPU difference: 2921.300000000064 / 2981.0500000000716 [-2.00%]
Total IMAGE difference: 44 / 14129 [0.31%]

- Replace various `Size()` calls with `Extent()`/`Length()` (int-returning) when passing element counts into `Message_ProgressScope`.
- Make “unsupported id type” fallbacks explicit in `BRepGraphInc_Storage` visitors to avoid MSVC control-path warnings.
- Minor warning-focused cleanups (loop variable rename in a test, use of `BRepGraph_NodeId::Invalid()`, removal of duplicated `Standard_EXPORT`).
@github-actions
Copy link
Copy Markdown

Performance Test Summary

Commit: 1b99d77c68de67f56473fae2ed2d7cc91a1be489

Title: Merge 91be8c4 into 0ebbbed

Platform: macos-x64

Total MEMORY difference: 353859 / 366816 [-3.53%]
Total CPU difference: 5.329999999999996 / 5.6299999999999955 [-5.33%]
Total IMAGE difference: 0 / 0

Platform: windows-x64

Total MEMORY difference: 93074501 / 93022208 [+0.06%]
Total CPU difference: 3480.453125 / 3501.78125 [-0.61%]
Total IMAGE difference: 46 / 14249 [0.32%]

Platform: linux-clang-x64

Total MEMORY difference: 84126007 / 84152484 [-0.03%]
Total CPU difference: 3010.440000000166 / 2980.9400000000714 [+0.99%]
Total IMAGE difference: 1394 / 14129 [9.87%]

)

Apply some fixes where aaa82fc introduce as a regressions
@github-actions
Copy link
Copy Markdown

Performance Test Summary

Commit: 6abfc6cc56ccaebe2a0af1d8df46aea230c38072

Title: Merge 883cece into 0ebbbed

Platform: macos-x64

Total MEMORY difference: 364774 / 366816 [-0.56%]
Total CPU difference: 5.589999999999995 / 5.6299999999999955 [-0.71%]
Total IMAGE difference: 0 / 0

Platform: windows-x64

Total MEMORY difference: 93172437 / 93021824 [+0.16%]
Total CPU difference: 3475.28125 / 3501.75 [-0.76%]
Total IMAGE difference: 1094 / 14248 [7.68%]

Platform: linux-clang-x64

Total MEMORY difference: 84079452 / 84155361 [-0.09%]
Total CPU difference: 2859.330000000096 / 2981.0300000000716 [-4.08%]
Total IMAGE difference: 38 / 14129 [0.27%]

- Adjusted faulties and warnings in tests for IGES and STEP files to reflect updated results.
- Corrected tolerance values in multiple tests to ensure accuracy in shape validation.
- Updated expected label counts and properties in several test cases to align with new outputs.
- Modified error messages and expected results in HLR and offset tests for consistency.
- Refined metadata checks in GLTF and STEP tests to match revised reference sizes and values.
- Update Improvements cases with removing TODO
@github-actions
Copy link
Copy Markdown

Performance Test Summary

Commit: 133df0b16f581f07daf37ad8e744f10731a89478

Title: Merge 04025d1 into 0ebbbed

Platform: macos-x64

Total MEMORY difference: 355523 / 366816 [-3.08%]
Total CPU difference: 4.93 / 5.6299999999999955 [-12.43%]
Total IMAGE difference: 0 / 0

Platform: windows-x64

Total MEMORY difference: 93126642 / 93022208 [+0.11%]
Total CPU difference: 2588.578125 / 3501.78125 [-26.08%]
Total IMAGE difference: 40 / 14249 [0.28%]

Platform: linux-clang-x64

Total MEMORY difference: 84055337 / 84154778 [-0.12%]
Total CPU difference: 2859.780000000114 / 2981.0200000000714 [-4.07%]
Total IMAGE difference: 39 / 14129 [0.28%]

@dpasukhi dpasukhi merged commit 04025d1 into master Apr 30, 2026
16 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Maintenance Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. IR Integration request (Used for marking PR as a collection of multiple integration for master)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants