disallow Points #356
Open
disallow Points #356
+89
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
unlinked from
issues
Jan 31, 2025
jdries
reviewed
Feb 10, 2025
jdries
requested changes
Feb 10, 2025
Open-EO/openeo-geopyspark-driver#996 Co-authored-by: Jeroen Dries <[email protected]>
soxofaan
reviewed
Feb 11, 2025
| return _contains_polygon(geojson["geometry"]) | ||
|
|
||
| if geojson["type"] == "FeatureCollection": | ||
| return any(_contains_polygon(feature) for feature in geojson["features"]) |
There was a problem hiding this comment.
given Open-EO/openeo-processes#527 / Open-EO/openeo-processes#528 I think that should be all instead of any
(and the function should be named _contains_only_polygons)
| if geojson["type"] == "FeatureCollection": | ||
| return any(_contains_polygon(feature) for feature in geojson["features"]) | ||
|
|
||
| if geojson["type"] == "GeometryCollection": |
There was a problem hiding this comment.
I would not add support for this deprecated type, or is it necessary because we still coerce to GeometryCollection in several other places unfortunately?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open-EO/openeo-geopyspark-driver#996