Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken no-whitespace-issues-in-git lint job #2641

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

matrss
Copy link
Collaborator

@matrss matrss commented Feb 11, 2025

Purpose of PR?:

Fixes #2640. I only opened the .ui file in the Qt designer and saved it, which fixed the trailing whitespace issue.

Does this PR introduce a breaking change?

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Does this PR results in some Documentation changes?
If yes, include the list of Documentation changes

Checklist:

  • Bug fix. Fixes #
  • New feature (Non-API breaking changes that adds functionality)
  • PR Title follows the convention of <type>: <subject>
  • Commit has unit tests

@ReimarBauer
Copy link
Member

That is strange I did this too. Maybe an OS dependent problem? but ok when it is fixed now. that way.

@matrss
Copy link
Collaborator Author

matrss commented Feb 12, 2025

Yeah, considering the ".AppleSystemUIFont" that was in the .ui file this might have been a macOS-specific issue.

@matrss matrss merged commit 12d03d5 into Open-MSS:develop Feb 12, 2025
7 of 10 checks passed
@matrss matrss deleted the fix-broken-lint-job branch February 12, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"no-whitespace-issues-in-git" lint action broken
2 participants