-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
star citizen gamefixes #145
Conversation
gamefixes-umu/umu-starcitizen.py
Outdated
# patch libcuda to workaround crashes related to DLSS | ||
# See: https://github.com/jp7677/dxvk-nvapi/issues/174#issuecomment-2227462795 | ||
util.patch_libcuda() | ||
|
||
# RSI Launcher depends on powershell | ||
util.protontricks('powershell') | ||
|
||
# RSI Launcher fonts | ||
util.protontricks('arial') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind elaborating a bit why the fake Arial font bundled in Proton is insufficient and how it can be missing?
See:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ask this because if missing fonts only happens for only a subset of users then I don't think it would be fair to enforce installing it for everyone as some font installations can be 100MB+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the size increase of the prefix, there's also the download and installation time of the winetricks verb. Some of them take really long (e.g., wmp11) so doing more than necessary would be a pretty bad UX
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the worst case, with allfonts
, it can take 2 min+.
See this interesting project on how the installation of the some font-related verbs can be sped up, but with some risks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the report was from nix users, they were using the release tar.gz of proton-ge. with fonts missing certain inputs and buttons don't always render. if this is too much an edge case given the performance impact the font lines can be removed as well. installers such as lutris includes them already
Z:\
instead ofC:\
Addarial
andtahoma
fonts that are missing for some userslibglesv2
set tobuiltin
improves RSI Launcher animation responsiveness