Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

star citizen gamefixes #145

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Conversation

mactan-sc
Copy link
Contributor

@mactan-sc mactan-sc commented Oct 5, 2024

  • Remove EAC workaround
    • Enforcement is being enabled in Star Citizen 3.24.2
    • A solution for EAC has been identified, requiring user action in the RSI Launcher to change game files to a location on Z:\ instead of C:\
  • Add arial and tahoma fonts that are missing for some users
  • libglesv2 set to builtin improves RSI Launcher animation responsiveness

# patch libcuda to workaround crashes related to DLSS
# See: https://github.com/jp7677/dxvk-nvapi/issues/174#issuecomment-2227462795
util.patch_libcuda()

# RSI Launcher depends on powershell
util.protontricks('powershell')

# RSI Launcher fonts
util.protontricks('arial')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ask this because if missing fonts only happens for only a subset of users then I don't think it would be fair to enforce installing it for everyone as some font installations can be 100MB+

Copy link
Member

@R1kaB3rN R1kaB3rN Oct 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the size increase of the prefix, there's also the download and installation time of the winetricks verb. Some of them take really long (e.g., wmp11) so doing more than necessary would be a pretty bad UX

Copy link
Member

@R1kaB3rN R1kaB3rN Oct 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the worst case, with allfonts, it can take 2 min+.

See this interesting project on how the installation of the some font-related verbs can be sped up, but with some risks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the report was from nix users, they were using the release tar.gz of proton-ge. with fonts missing certain inputs and buttons don't always render. if this is too much an edge case given the performance impact the font lines can be removed as well. installers such as lutris includes them already

@R1kaB3rN R1kaB3rN merged commit de84c92 into Open-Wine-Components:master Oct 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants