Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update import_saves_folder to better accomodate for transfering saves from demos that save in the same location as the full game #227

Merged

Conversation

UsernamesAreNotMyThing
Copy link
Contributor

@UsernamesAreNotMyThing UsernamesAreNotMyThing commented Feb 14, 2025

This adds an additional parameter to import_saves_folder to allow the function to copy files from the other prefix's folder instead of symlinking the whole folder. This is good for demos that save to the same location as the full game, especially if the full game had already made that folder. This also means that save files from the demo won't be deleted if you delete the demo's prefix.

Additionally, the save locations for some games need the user's 17-digit Steam account ID, which the Steam client doesn't offer as an environment variable. This also adds a function to make that easier through reading Steam's loginusers.vdf file.

#217 (comment)

My interpretation of the added code is that the whole folder referenced in the script is symlinked into the current game, but this wouldn't work out very well when the folder is the same such as in the cases of Metaphor and Octopath Traveler 2, especially if the game had already created the save folder and stored some data into it already.

@UsernamesAreNotMyThing UsernamesAreNotMyThing changed the title Update import_saves_folder Update import_saves_folder to better accomodate for transfering saves from demos Feb 15, 2025
@UsernamesAreNotMyThing UsernamesAreNotMyThing changed the title Update import_saves_folder to better accomodate for transfering saves from demos Update import_saves_folder to better accomodate for transfering saves from demos that save in the same location as the full game Feb 16, 2025
@GloriousEggroll GloriousEggroll merged commit ffa477c into Open-Wine-Components:master Feb 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants