io: fix buffer overflow in metal_sys_io_mem_map() #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmooring
requested changes
Feb 11, 2025
In metal_sys_io_mem_map() if the I/O region size is a multiple of (1<<page_shift) will result in a buffer overflow in the for loop. Therefore, adjust loop termination condition to prevent accessing an out-of-bounds page. Signed-off-by: Iuliana Prodan <[email protected]>
iuliana-prodan
force-pushed
the
fix_buffer_overflow
branch
from
a584a99 to
9979981
Compare
Done. |
tnmysh
reviewed
Feb 11, 2025
tnmysh
approved these changes
Feb 11, 2025
arnopo
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In metal_sys_io_mem_map() if the I/O region size
is a multiple of (1<<page_shift) will result in a
buffer overflow in the for loop.
Therefore, adjust loop termination condition to
prevent accessing an out-of-bounds page.