Skip to content

Conversation

@Elelan
Copy link

@Elelan Elelan commented Dec 5, 2025

Extracted Dweb into separate activity
decoupled from Main App

What / Why

  • Isolated Snowbird flows into their own SnowbirdActivity with a dedicated nav graph and host layout, removing cross-activity fragment navigation.
  • Added Snowbird-specific success screen (SnowbirdSetupSuccessFragment) and rewired create/join flows to launch success directly without hopping through SpaceSetupActivity.
  • Updated success navigation to reset the Snowbird back stack to the dashboard and ensure the toolbar/back button exits to the previous activity when on the dashboard.
  • Simplified Snowbird fragments to assume a single host (SnowbirdActivity), removing fallback host checks and redundant SafeArgs handling.

Key Changes

  • New SnowbirdActivity and layout; manifest entry for Snowbird.
  • Snowbird nav graph now starts at the dashboard, includes the Snowbird success screen, and routes create/join → success → dashboard/share.
  • SnowbirdSetupSuccessFragment uses nav ID navigation (no ActionOnlyNavDirections) and pops up to the graph root to avoid back-stack loops.
  • BaseSnowbirdFragment now owns dialog/analytics lifecycle and toolbar updates for Snowbird only.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@prathieshna
Copy link

LGTM - Merging this on the basis that this will be later migrated to compose and all this will be made in a way that it can be integrated just like IA or Private cloud. @Elelan please do create a tech debt card and attach this PR please.

@prathieshna prathieshna merged commit 319c02d into next Dec 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants