fix: fix write-buffer-size overflow #3185

Z-G-H1 · 2025-11-05T10:05:45Z

No description provided.

* fix: codis-dashboard uses 100% cpu(OpenAtomFoundation#2332) (OpenAtomFoundation#2393) Co-authored-by: liuchengyu <[email protected]> * fix: The role displayed on the first Server in the Group area of the codis-fe is incorrect (OpenAtomFoundation#2350) (OpenAtomFoundation#2387) Co-authored-by: liuchengyu <[email protected]> --------- Co-authored-by: Chengyu Liu <[email protected]> Co-authored-by: liuchengyu <[email protected]>

* fix: codis-dashboard uses 100% cpu(OpenAtomFoundation#2332) (OpenAtomFoundation#2393) Co-authored-by: liuchengyu <[email protected]> * fix: The role displayed on the first Server in the Group area of the codis-fe is incorrect (OpenAtomFoundation#2350) (OpenAtomFoundation#2387) Co-authored-by: liuchengyu <[email protected]> * fix: automatic fix master-slave replication relationship after master or slave service restarted (OpenAtomFoundation#2373, OpenAtomFoundation#2038, OpenAtomFoundation#1950, OpenAtomFoundation#1967, OpenAtomFoundation#2351)) (OpenAtomFoundation#2386) Co-authored-by: liuchengyu <[email protected]> * feat:add 3.5.3 changelog (OpenAtomFoundation#2395) * add 3.5.3 changelog --------- Co-authored-by: chejinge <[email protected]> --------- Co-authored-by: Chengyu Liu <[email protected]> Co-authored-by: liuchengyu <[email protected]> Co-authored-by: chejinge <[email protected]>

…on#2431) OpenAtomFoundation#2429 Signed-off-by: HappyUncle <[email protected]>

…dation#2411) * add kubeblock component post start demo * convert pika kubeblocks helm chart to new component definition api (cherry picked from commit 60535d6) * modify cluster yaml * remove dirty code * refine pika cluster yaml * add PIKA_CODIS_DASHBOARD_SVC_NAME var reference

OpenAtomFoundation#2425 Signed-off-by: HappyUncle <[email protected]>

Co-authored-by: wuxianrong <[email protected]>

Co-authored-by: 白鑫 <[email protected]>

…mission judgment after the default user is connected (OpenAtomFoundation#2449)

… not exist or doing bgsave(OpenAtomFoundation#2289) (OpenAtomFoundation#2437) Co-authored-by: liuchengyu <[email protected]>

…kipped directly(OpenAtomFoundation#2433) (OpenAtomFoundation#2439) Co-authored-by: liuchengyu <[email protected]>

…omFoundation#2456) (OpenAtomFoundation#2457) Co-authored-by: liuchengyu <[email protected]>

Co-authored-by: wuxianrong <[email protected]>

* fix: ACL user authentication errors * blacklist instead of acl user * add rename command (OpenAtomFoundation#2462) * support config get userblacklist ---------

…omFoundation#2467) Co-authored-by: liuyuecai <[email protected]>

…top (OpenAtomFoundation#2475) Co-authored-by: liuchengyu <[email protected]>

Co-authored-by: liuchengyu <[email protected]>

…dation#2474) Co-authored-by: liuchengyu <[email protected]>

…enAtomFoundation#2458) Co-authored-by: liuchengyu <[email protected]>

…#2451) Co-authored-by: liuchengyu <[email protected]>

add rename-command go test

…enAtomFoundation#2473) Co-authored-by: liuchengyu <[email protected]>

…omFoundation#2839) * fix: PkPatternMatchDel inconsistent between rediscache and db --------- Co-authored-by: haiyang426 <[email protected]> Co-authored-by: chejinge <[email protected]>

* multi command throught cache

Co-authored-by: chejinge <[email protected]>

…dation#2829) * Added the serverlog periodic reclamation function --------- Co-authored-by: cheniujh <[email protected]>

* fix:355 CI --------- Co-authored-by: chejinge <[email protected]>

* fix conflicts --------- Co-authored-by: liuyuecai <[email protected]>

* fix the problem of blpop don't update cache

… CI (OpenAtomFoundation#2863)

…#2862) * kill conns correct in WorkThread

* 1. make pika support redis sentinel 2. support client kill type pubsub/normal 3. ensure fd is removed in epoll if server wanna close fd * fix exit process: 1. ensure NetWork Thread(Dispacher) can be stopped in time 2. ensure all queued Async WriteDB task can be done before exit --------- Co-authored-by: chejinge <[email protected]>

This reverts commit 8253d48.

* fix:fix 355 CI --------- Co-authored-by: chejinge <[email protected]>

* fix: pika slave support multi/exec cmd OpenAtomFoundation#2422 Signed-off-by: HappyUncle <[email protected]> * fix: pika slave support watch cmd OpenAtomFoundation#2422 Signed-off-by: HappyUncle <[email protected]> * test: add replication-test-go, let slave support watch/unwatch/multi/exec/discard Signed-off-by: HappyUncle <[email protected]> --------- Signed-off-by: HappyUncle <[email protected]>

…ace ERR Server in read-only in go test (OpenAtomFoundation#2866)

…TaskManager (OpenAtomFoundation#2794) * changed the returned timeout of TimerTaskManager --------- Co-authored-by: cheniujh <[email protected]>

* fix:not correct used bgsave_info_ * fix:not correct used bgsave_info_ --------- Co-authored-by: chejinge <[email protected]>

…able (OpenAtomFoundation#2692) * change cmdId assignment time to assign after intializing cmdtable * 修改 PikaCmdTableManager中 getCmdId，删除pika_command.cc中多余的头文件引用

* fix:changelog --------- Co-authored-by: Xin.Zh <[email protected]>

coderabbitai · 2025-11-05T10:06:09Z

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

76 files out of 293 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

chejinge and others added 30 commits February 7, 2024 14:45

Update pika_migrate_thread.cc (OpenAtomFoundation#2415)

00d628d

fix lock

58d31dc

fix lock

f7222d7

Update pika_version.h (OpenAtomFoundation#2443)

ab103b6

fix: ACL user authentication errors

1bbd402

add rename command (OpenAtomFoundation#2462)

469fce0

fix: Fix the problem of possible slave_key conflict (OpenAtomFoundati…

ccd0b58

…on#2431) OpenAtomFoundation#2429 Signed-off-by: HappyUncle <[email protected]>

feat: support dynamic set max-conn-rbuf-size (OpenAtomFoundation#2434)

6820de4

OpenAtomFoundation#2425 Signed-off-by: HappyUncle <[email protected]>

fix ci replication go test failed problem (OpenAtomFoundation#2435)

8076ce9

Co-authored-by: wuxianrong <[email protected]>

fix not syncing (OpenAtomFoundation#2430)

bd708a9

Co-authored-by: 白鑫 <[email protected]>

Fix the initial authentication status of the ACL user and the ACL per…

1754e91

…mission judgment after the default user is connected (OpenAtomFoundation#2449)

fix: return kErr status when Master handle MetaRsync reqeust if db is…

e4b8ab8

… not exist or doing bgsave(OpenAtomFoundation#2289) (OpenAtomFoundation#2437) Co-authored-by: liuchengyu <[email protected]>

fix: after full synchronization fails, full synchronization will be s…

d6f46dd

…kipped directly(OpenAtomFoundation#2433) (OpenAtomFoundation#2439) Co-authored-by: liuchengyu <[email protected]>

fix: linux arm64 spelling mistake in Makefile of pika_exporter(OpenAt…

0c2a67c

…omFoundation#2456) (OpenAtomFoundation#2457) Co-authored-by: liuchengyu <[email protected]>

add tcl go test (OpenAtomFoundation#2464)

dbf8e56

Co-authored-by: wuxianrong <[email protected]>

fix: acl forward compatible (OpenAtomFoundation#2459)

b32d881

* fix: ACL user authentication errors * blacklist instead of acl user * add rename command (OpenAtomFoundation#2462) * support config get userblacklist ---------

Integration tests differentiate between cached and non-cached (OpenAt…

94e85a5

…omFoundation#2467) Co-authored-by: liuyuecai <[email protected]>

feat:add issue translation robot (OpenAtomFoundation#2478)

89f2b01

fix: support removing pika instance from codis dashboard before pod s…

bc3b829

…top (OpenAtomFoundation#2475) Co-authored-by: liuchengyu <[email protected]>

fix: support saving pika config to hostpath (OpenAtomFoundation#2476)

66039a1

Co-authored-by: liuchengyu <[email protected]>

fix: no namespace in configmap, so remove the namespace (OpenAtomFoun…

d8a1015

…dation#2474) Co-authored-by: liuchengyu <[email protected]>

fix: move Dockerfile and build_docker.sh into docker subdirectory (Op…

400bf49

…enAtomFoundation#2458) Co-authored-by: liuchengyu <[email protected]>

feat: support building pika_exporter docker image (OpenAtomFoundation…

aa79542

…#2451) Co-authored-by: liuchengyu <[email protected]>

add rename-command go test (OpenAtomFoundation#2468)

81aa1ff

add rename-command go test

ci: cleanup code (OpenAtomFoundation#2479)

78319c1

feat: support deploying pika_exporter components using kubeblocks (Op…

04adc56

…enAtomFoundation#2473) Co-authored-by: liuchengyu <[email protected]>

fix: fix github action CI failure (OpenAtomFoundation#2491)

6f8b0d8

chejinge and others added 24 commits August 7, 2024 15:52

fix: PkPatternMatchDel inconsistent between rediscache and db (OpenAt…

4a9872c

…omFoundation#2839) * fix: PkPatternMatchDel inconsistent between rediscache and db --------- Co-authored-by: haiyang426 <[email protected]> Co-authored-by: chejinge <[email protected]>

fix: multi command through cache (OpenAtomFoundation#2812)

f804191

* multi command throught cache

feat:incr send binlog withttl (OpenAtomFoundation#2833)

f61950e

Co-authored-by: chejinge <[email protected]>

feat:Added the periodically clearing serverlog function (OpenAtomFoun…

a111966

…dation#2829) * Added the serverlog periodic reclamation function --------- Co-authored-by: cheniujh <[email protected]>

fix:355 CI (OpenAtomFoundation#2851)

74b952f

* fix:355 CI --------- Co-authored-by: chejinge <[email protected]>

test: fix multi bug and compatible ACL test (OpenAtomFoundation#2844)

9afe5af

* fix conflicts --------- Co-authored-by: liuyuecai <[email protected]>

fix:update version (OpenAtomFoundation#2856)

6bc2a47

make flushall write binlog of flushdb (OpenAtomFoundation#2846)

e515a93

fix: blpop/brpop don't update cache (OpenAtomFoundation#2858)

7576790

* fix the problem of blpop don't update cache

change the network time out from 60 to 500 to avoid some fake fail in…

0c2e083

… CI (OpenAtomFoundation#2863)

fix: kill connections correctly in Net WorkThread (OpenAtomFoundation…

88f8d70

…#2862) * kill conns correct in WorkThread

fix CI

8253d48

Revert "fix CI"

3ae7718

This reverts commit 8253d48.

fix:fix 355 CI (OpenAtomFoundation#2864)

84b234f

* fix:fix 355 CI --------- Co-authored-by: chejinge <[email protected]>

fix CI

5911dc5

use ERR READONLY You can't write against a read only replica. to repl…

cd97872

…ace ERR Server in read-only in go test (OpenAtomFoundation#2866)

fix centos compile support (OpenAtomFoundation#2865)

aa59b40

fix: changed the calculating logic of epoll timeout provided by Timer…

1c66a03

…TaskManager (OpenAtomFoundation#2794) * changed the returned timeout of TimerTaskManager --------- Co-authored-by: cheniujh <[email protected]>

fix:not correct used bgsave_info_ (OpenAtomFoundation#2745)

7dcd4f6

* fix:not correct used bgsave_info_ * fix:not correct used bgsave_info_ --------- Co-authored-by: chejinge <[email protected]>

fix: modify cmdId assignment time to assgining after registering cmdt…

2eb389f

…able (OpenAtomFoundation#2692) * change cmdId assignment time to assign after intializing cmdtable * 修改 PikaCmdTableManager中 getCmdId，删除pika_command.cc中多余的头文件引用

fix: v3.5.5 changelog patch (OpenAtomFoundation#2877)

56ce467

* fix:changelog --------- Co-authored-by: Xin.Zh <[email protected]>

修复v3.5.5版本中write-buffer-size溢出问题

58cc4dd

github-actions bot added Invalid PR Title ☢️ Bug Something isn't working 📒 Documentation Improvements or additions to documentation labels Nov 5, 2025

Z-G-H1 changed the title ~~fix write-buffer-size overflow~~ fix: fix write-buffer-size overflow Nov 5, 2025

github-actions bot removed the Invalid PR Title label Nov 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: fix write-buffer-size overflow #3185

fix: fix write-buffer-size overflow #3185

Uh oh!

Z-G-H1 commented Nov 5, 2025

Uh oh!

coderabbitai bot commented Nov 5, 2025

Review skipped

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

28 participants

fix: fix write-buffer-size overflow #3185

Are you sure you want to change the base?

fix: fix write-buffer-size overflow #3185

Uh oh!

Conversation

Z-G-H1 commented Nov 5, 2025

Uh oh!

coderabbitai bot commented Nov 5, 2025

Review skipped

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

28 participants