Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only print constraint warning once #50

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Only print constraint warning once #50

merged 2 commits into from
Jun 19, 2024

Conversation

lohedges
Copy link
Contributor

This PR adds a small fix to ensure that the asymmetric constraint warning is only printed once, i.e. it isn't duplicated if multiple constraints don't match between end states. I've also added an initial check to make sure that the number of constraints is the same, then check each constraint one-by-one.

@lohedges lohedges added the bug Something isn't working label Jun 19, 2024
@lohedges lohedges requested a review from mb2055 June 19, 2024 10:36
@lohedges
Copy link
Contributor Author

I'm confused by the CI errors for macOS. I had assumed that this would be fixed when the latest Sire and BioSimSpace packages were built.

  Could not solve for environment specs
  The following packages are incompatible
  └─ biosimspace is not installable because there are no viable options
     ├─ biosimspace [2023.1.0|2023.1.1] would require
     │  └─ sire ~=2023.1.0 , which does not exist (perhaps a missing channel);
     ├─ biosimspace 2023.1.2 would require
     │  └─ sire ~=2023.1.3 , which does not exist (perhaps a missing channel);
     ├─ biosimspace 2023.2.0 would require
     │  └─ sire ~=2023.2.0 , which does not exist (perhaps a missing channel);
     ├─ biosimspace 2023.4.0.dev would require
     │  └─ sire 2023.4.0.dev , which does not exist (perhaps a missing channel);
     ├─ biosimspace 2023.5.0.dev would require
     │  └─ sire 2023.5.0.dev , which does not exist (perhaps a missing channel);
     └─ biosimspace 2024.1.0.dev would require
        └─ sire 2024.1.0.dev , which does not exist (perhaps a missing channel).

Perhaps this runner is still running macOS x64, not arm64?

@lohedges
Copy link
Contributor Author

I also don't understand this bit:

  Warning: 
  LibMambaUnsatisfiableError: Encountered problems while solving:
    - nothing provides sire ~=2023.1.0 needed by biosimspace-2023.1.0-py38_0

We are explicitly using py311 in our CI build matrix, so why is it complaining about a dependency for py38? There are similar errors for Windows:

 Warning: 
 LibMambaUnsatisfiableError: Encountered problems while solving:
   - nothing provides sire ~=2023.1.0 needed by biosimspace-2023.1.0-py38_0
 
 Could not solve for environment specs
 The following packages are incompatible
 \u251c\u2500 biosimspace is installable with the potential options
 \u2502  \u251c\u2500 biosimspace [2023.1.0|2023.1.1] would require
 \u2502  \u2502  \u2514\u2500 sire ~=2023.1.0 , which does not exist (perhaps a missing channel);
 \u2502  \u251c\u2500 biosimspace 2023.1.2 would require
 \u2502  \u2502  \u2514\u2500 sire ~=2023.1.3 , which does not exist (perhaps a missing channel);
 \u2502  \u251c\u2500 biosimspace 2023.2.0 would require
 \u2502  \u2502  \u2514\u2500 sire ~=2023.2.0 , which does not exist (perhaps a missing channel);
 \u2502  \u251c\u2500 biosimspace 2023.4.0.dev would require
 \u2502  \u2502  \u2514\u2500 sire 2023.4.0.dev , which does not exist (perhaps a missing channel);
 \u2502  \u251c\u2500 biosimspace 2023.5.0.dev would require
 \u2502  \u2502  \u2514\u2500 sire 2023.5.0.dev , which does not exist (perhaps a missing channel);
 \u2502  \u251c\u2500 biosimspace 2024.1.0.dev would require
 \u2502  \u2502  \u2514\u2500 sire 2024.1.0.dev , which does not exist (perhaps a missing channel);
 \u2502  \u2514\u2500 biosimspace 2024.2.0.dev would require
 \u2502     \u2514\u2500 python_abi 3.12.* *_cp312, which requires
 \u2502        \u2514\u2500 python 3.12.* *_cpython, which can be installed;
 \u2514\u2500 python 3.11**  is not installable because it conflicts with any installable versions previously reported.

The conda environment should be created using ${{ matrix.python-version }}. This is what we do for Sire and BioSimSpace and don't have any similar issues there.

Copy link
Contributor

@mb2055 mb2055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good (apart from the CI issues) 👍

@lohedges
Copy link
Contributor Author

For macOS I see the following:

Platform: osx-64

Whereas for Sire and BioSimSpace it's:

Platform: osx-arm64

I'm not sure why we repeatedly get osx-64 runners for this repo, whereas the others are now osx-arm64. Both specify macos-latest in the CI config.

@lohedges lohedges merged commit f35fd29 into main Jun 19, 2024
4 of 6 checks passed
@lohedges lohedges deleted the fix_constraint_check branch June 19, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants