-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only print constraint warning once #50
Conversation
I'm confused by the CI errors for macOS. I had assumed that this would be fixed when the latest Sire and BioSimSpace packages were built.
Perhaps this runner is still running macOS x64, not arm64? |
I also don't understand this bit:
We are explicitly using py311 in our CI build matrix, so why is it complaining about a dependency for py38? There are similar errors for Windows:
The conda environment should be created using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good (apart from the CI issues) 👍
For macOS I see the following:
Whereas for Sire and BioSimSpace it's:
I'm not sure why we repeatedly get |
This PR adds a small fix to ensure that the asymmetric constraint warning is only printed once, i.e. it isn't duplicated if multiple constraints don't match between end states. I've also added an initial check to make sure that the number of constraints is the same, then check each constraint one-by-one.