Added macos support for libcyphal_demo - UDP only transport. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a) can't combine filters (like `| EVFILT_VNODE`) b) wrong `EV_CLEAR` usage c) wrong `NOTE_xxx` usage
plus some build fixes Simplifying Nunavut integration Using Nunavut as a submodule now provides all dependencies including pydsdl, public_regulated_data_types, and cmake integration.
thirtytwobits
approved these changes
Mar 3, 2025
| - name: get nunavut | ||
| run: > | ||
| pip install git+https://github.com/OpenCyphal/[email protected] | ||
| - name: Install Ninja |
There was a problem hiding this comment.
can we just use the toolshed container?
There was a problem hiding this comment.
I'll try in the separate pr.
#37
|
|
||
| - name: Configure CMake | ||
| run: cmake -B ${{github.workspace}}/libcyphal_demo/build -DCMAKE_BUILD_TYPE=${{matrix.build_type}} ${{github.workspace}}/libcyphal_demo | ||
| run: cd ${{github.workspace}}/libcyphal_demo && cmake --preset Demo-Linux |
There was a problem hiding this comment.
- name: Configure CMake
working-directory: libcyphal_demo
run: >
cmake --workflow --preset Demo-Linux-Workflow
| "configurePreset": "Demo-Linux", | ||
| "configuration": "Release" | ||
| } | ||
| ] |
There was a problem hiding this comment.
Add workflows so we control the definition of CI builds here instead of in github actions.
There was a problem hiding this comment.
I'll try the workflows in separate pr. #38
pavel-kirienko
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a) can't combine filters (like
| EVFILT_VNODE)b) wrong
EV_CLEARusagec) wrong
NOTE_xxxusageAlso cherry-pick of commit 54cee7d by Scott Dixon, plus some build fixes.