Add RM1 MHK Multi-Rotor examples to regression test suite #3041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zation of these models
deslaughter
added
Module: AeroDyn
Feature: Linearization
Feature: MHK
There was a problem hiding this comment.
Pull Request Overview
This PR adds regression tests for the RM1 MHK floating underwater turbine with multi-rotor capabilities. It includes a time domain simulation test and a linearization test, along with supporting code changes to enable proper testing of multi-rotor MHK turbines.
Key changes:
- Added two new regression tests:
MHK_RM1_Floating_MRfor time domain simulation andMHK_RM1_Floating_MR_Linearfor linearization - Fixed cavitation check to skip when no wake model is active
- Removed an outdated MHK linearization warning
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| reg_tests/r-test | Updated subproject commit to include new test cases |
| reg_tests/executeOpenfastLinearRegressionCase.py | Disabled MBC3 execution after linearization due to multi-rotor crashes |
| reg_tests/CTestList.cmake | Added new multi-rotor regression tests to the test suite |
| modules/openfast-library/src/FAST_Subs.f90 | Removed warning about MHK linearization limitations |
| modules/aerodyn/src/AeroDyn_Inflow_C_Binding_Types.f90 | Minor formatting changes to CONTAINS statement |
| modules/aerodyn/src/AeroDyn.f90 | Added check to skip cavitation calculation when no wake model is used |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
…nvalid output variables
|
This PR now includes the wind-based multi-rotor simulation on a floating platform from @luwang00 |
luwang00
approved these changes
Oct 31, 2025
| of_regression("5MW_OC3Spar_DLL_WTurb_WavesIrr" "openfast;elastodyn;aerodyn;servodyn;hydrodyn;map;offshore") | ||
| of_regression("5MW_OC4Semi_WSt_WavesWN" "openfast;elastodyn;aerodyn;servodyn;hydrodyn;moordyn;offshore") | ||
| # of_regression("5MW_OC4Semi_WSt_WavesWN_MR" "openfast;elastodyn;aerodyn;servodyn;hydrodyn;moordyn;multirotor;offshore") | ||
| of_regression("5MW_MRSemi_DLL_WSt_WavesIrr" "openfast;elastodyn;aerodyn;servodyn;hydrodyn;moordyn;offshore,multirotor") |
There was a problem hiding this comment.
Hi @deslaughter, please also add subdyn and olaf here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to merge.
Feature or improvement description
This PR adds two regression tests which demonstrate the new multi-rotor capabilities of OpenFAST. The first one performs a time domain simulation of the RM1 MHK floating underwater turbine with 2 rotors. The second uses the same model, but performs linearization at 0.5 seconds.
Impacted areas of the software
r-testAdditional supporting information
Code was added to skip the cavitation check in AeroDyn when
Wake_Mod == WakeMod_nonesince there is no relative velocity in this case.An existing warning for MHK linearization was removed.
Code was previously added to run MBC3 after linearization to the
executeOpenfastLinearRegressionCase.pybut this code now crashes when running multi-rotor simulations so it was disabled.