Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better credential error logging #900

Merged
merged 2 commits into from
Mar 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions integration-tests/worker/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# @openfn/integration-tests-worker

## 1.0.80

### Patch Changes

- Updated dependencies [e2f1197]
- @openfn/[email protected]
- @openfn/[email protected]
- @openfn/[email protected]

## 1.0.79

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion integration-tests/worker/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@openfn/integration-tests-worker",
"private": true,
"version": "1.0.79",
"version": "1.0.80",
"description": "Lightning WOrker integration tests",
"author": "Open Function Group <[email protected]>",
"license": "ISC",
Expand Down
6 changes: 6 additions & 0 deletions packages/engine-multi/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# engine-multi

## 1.6.1

### Patch Changes

- e2f1197: Better logging on credential errors

## 1.6.0

### Minor Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/engine-multi/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@openfn/engine-multi",
"version": "1.6.0",
"version": "1.6.1",
"description": "Multi-process runtime engine",
"main": "dist/index.js",
"type": "module",
Expand Down
4 changes: 2 additions & 2 deletions packages/engine-multi/src/api/preload-credentials.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ export default async (
job.configuration = await loader(config as string);
logger?.debug(`Credential ${config} loaded OK (${config})`);
} catch (e: any) {
logger?.debug(`Error loading credential ${config}`);
logger?.error(`Error loading credential ${config}`, e);
errors.push({
id: config,
step: step.id!,
error: e?.message || e?.toString() || e,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This toString thing is causing [object | Object] to come out of logs.

error: e?.message || e,
});
}
resolve();
Expand Down
7 changes: 7 additions & 0 deletions packages/lightning-mock/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# @openfn/lightning-mock

## 2.1.3

### Patch Changes

- Updated dependencies [e2f1197]
- @openfn/[email protected]

## 2.1.2

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/lightning-mock/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@openfn/lightning-mock",
"version": "2.1.2",
"version": "2.1.3",
"private": true,
"description": "A mock Lightning server",
"main": "dist/index.js",
Expand Down
8 changes: 8 additions & 0 deletions packages/ws-worker/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# ws-worker

## 1.12.1

### Patch Changes

- e2f1197: Better logging on credential errors
- Updated dependencies [e2f1197]
- @openfn/engine-multi@1.6.1

## 1.12.0

### Minor Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/ws-worker/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@openfn/ws-worker",
"version": "1.12.0",
"version": "1.12.1",
"description": "A Websocket Worker to connect Lightning to a Runtime Engine",
"main": "dist/index.js",
"type": "module",
Expand Down