-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving the scope of search results #71
Conversation
@xx621998xx I have already sent PR for the issue #65. |
@sakshee-19 That's cool! |
Nice work 👍 The issue (#70) is related to keywords like You have capitalized the first letters but this could be avoided by doing a matching after converting both data to lowercase. Instead, you must generate permutation in terms of order of words and separate them with Note that Kindly make appropriate changes and let us know when it is ready for review. 👍 |
@AdiChat I think we should always replace If you agree, I will implement this. |
@iattempt , we have already started working on the issue :) |
search/views.py
Outdated
perms.append(word[0].upper() + word[1:] ) | ||
count = count+1 | ||
p='_'.join(perms) | ||
final.append(p) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, we should sort combinations by length and/or else.
In general, one want get the most matched result with the tags she/he typed.
@iattempt Sure. I guess you are suggesting to remove the inconsistency in Cosmos structure and update the metadata generator. This will be great. 👍 @xx621998xx You can continue working on this issue, assuming, |
I think we should extract/refactor class by the function query in search/views. Could I work on this? |
@iattempt Sure, Go for it 👍 |
@AdiChat Kindly review the changes. |
You need to clean the files associated with this pull request. There are 119 files. Kindly take a look. 👍 |
Hi |
Checklist
develop
branch.Which issue does this PR fix?:
fixes: #65 #70
This PR resolves issue #70 (The random keywords in search box aren't always having a search result). Following is obtained upon typing "Logistic Regression" onto the searchbox.
The above search displays the correct results.
However, following is obtained upon typing "logistic regression" (which is basically one of the randomly generated keywords which show up upon launching Cosmos Search).
Finally, following is obtained upon typing "logistic regression" after widening the search scope a bit.
This PR also resolves the pluralization issue.
Why do we need this PR?:
Most users expect the same results while searching for "Logistic Regression", "logistic regression" etc. The search should be able to handle such cases. We aim to broaden the search experience of users through this PR and the PRs that follow.
@AdiChat Please review.
Thanks,
Team GalSquared | RGSoC