Skip to content

Fix Release v2.2.1#39

Merged
cornelius-koepp merged 15 commits into
v1from
v1dev
Aug 22, 2025
Merged

Fix Release v2.2.1#39
cornelius-koepp merged 15 commits into
v1from
v1dev

Conversation

@cornelius-koepp

@cornelius-koepp cornelius-koepp commented Aug 12, 2025

Copy link
Copy Markdown
Member

No description provided.

cornelius-koepp and others added 10 commits July 14, 2025 23:54
@cornelius-koepp cornelius-koepp added the bug Something isn't working label Aug 12, 2025
mumpf
mumpf reviewed Aug 13, 2025
View reviewed changes
Comment thread src/knx/memory.h Outdated
mumpf
mumpf reviewed Aug 13, 2025
View reviewed changes

@mumpf mumpf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clearMemory() ist nicht implementiert, wird aber auch nirgendwo aufgerufen. Ansonsten sieht das gut aus.

@cornelius-koepp cornelius-koepp mentioned this pull request Aug 13, 2025
Closed
Ing-Dom
Ing-Dom reviewed Aug 13, 2025
View reviewed changes
Comment thread README.md Outdated
@cornelius-koepp
fixup! Merge pull request thelsing#316 from thewhobox/fix/unloading
4010425 
Remove `clearMemory();` in Header as Result of Cherry-Pick
cornelius-koepp
cornelius-koepp commented Aug 14, 2025
View reviewed changes

@cornelius-koepp cornelius-koepp left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thewhobox Vorschlag zur Behandlung des (seltenen) Sonderfalls für den SaveTimeout. Bitte kritisch prüfen, ich kann es nicht testen.

Comment thread src/knx/memory.cpp
Comment thread src/knx/memory.cpp
@traxanos

traxanos commented Aug 14, 2025

Copy link
Copy Markdown
Member

das ist doch völlig überflüssig. jetzt hast du eine unnötige abweichung zum main repo.

@cornelius-koepp

cornelius-koepp commented Aug 14, 2025

Copy link
Copy Markdown
Member Author

unnötige abweichung zum main repo

In Commen wäre das ein Fall für delayTimerInit. Das Szenario tritt auf einem Gerät nur sehr sehr selten auf, aber wir können den Fall damit abhandeln, auch wenn der Ansatz nicht so richtig elegant ist. Und sollten das Thema dann nie wieder anfassen müssen.

Würde die entsprechende Änderung (wie alle Änderungen bei denen das möglich ist) auch wieder auf Upstream bereitstellen wollen, damit die Änderungen möglichst klein bleiben...

Ing-Dom and others added 3 commits August 15, 2025 12:34
@Ing-Dom
fixes #40
5d7dbd5 
only set the repeat flag for TP1 medium with TPUart when sending
@cornelius-koepp
Fix: Special Case Handling for Unload-Timeout
3330c55 
`_savedTimeout==0` is defined as no timeout running. Prevent this rare case.
@cornelius-koepp
Update v2.2.1 Release Day
7650c1f
@cornelius-koepp cornelius-koepp merged commit 1b646c1 into v1 Aug 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mumpf mumpf mumpf left review comments
@thewhobox thewhobox thewhobox approved these changes
@Ing-Dom Ing-Dom Ing-Dom approved these changes
@traxanos traxanos Awaiting requested review from traxanos

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cornelius-koepp @traxanos @Ing-Dom @mumpf @thewhobox @thelsing