Feature zoom - Do Not Merge #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sAndBubbles on App
tarrow
commented
Sep 13, 2018
| zoomedBubbleTargetRadius() { | ||
| return this.chartDimensions.width*0.5*0.5; | ||
| }, | ||
| getChartCenter() { |
Collaborator
Author
There was a problem hiding this comment.
IMHO this could be just chartCenter since it is used for a computed property
tarrow
commented
Sep 13, 2018
| > | ||
| <body style="word-wrap: break-word;"> | ||
| <div id="area_title" :style="{width: inscribedSquareLength + 'px', height: inscribedSquareLength + 'px'}"> | ||
| <div id="areborder: 1px #000 solid;a_title" :style="{width: inscribedSquareLength + 'px', height: inscribedSquareLength + 'px'}"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR for place to store comments on this work
Title of the PR - # issue (number) - description of the issue (could be copied from the issue itself)
example:
issue #444 - make the PDF modal resizable
Checklist:
My code follows the style guidelines of this project
The change is fulfilling its purpose and works in all browsers/environments
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
The change is in line with the design goals of Head Start
The changes fit our coding style
The changes do not negatively affect the different stakeholders of Headstart (end users, developers, designers, maintainers, deployers, users of Head Start as a library)