OLMIS-8125: Added user roles import/export functionality#146
OLMIS-8125: Added user roles import/export functionality#146
Conversation
…pervisory nodes only if provided
|
pwargulak
left a comment
pwargulak
left a comment
There was a problem hiding this comment.
No changes, just questions.
And one more question - did you export all roles from "demo startup" and import them again - how long it took?
|
|
||
| @Column(name = "type", insertable = false, updatable = false) | ||
| @Getter | ||
| private String type; |
There was a problem hiding this comment.
Is there a migration script for this column?
Migration script to add the column to table, and set proper value for existing Role Assignments?
This field doesn't seem to be set in the RoleAssignment's Constructor?
OK, I'll leave this comment for documentation, but just noticed it is @DiscriminatorColumn
There was a problem hiding this comment.
yes, it's discriminator column, it's not a new column created by me
| ); | ||
| } | ||
|
|
||
| private List<List<RoleAssignmentImportDto>> splitRoleItems( |
There was a problem hiding this comment.
Just to understand - this split splits by users? So all role assignments for one user will always be in the same batch?
There was a problem hiding this comment.
Yes, exactly. To avoid unnecessary issues/redundant actions for the same user.
yes, I tested it. 'Fresh' database (around 2k entries (users + role assignments)) export works instantly. Maximum data batch I have tested was ~4k users, ~10k role assignments (~14k entries in total) took around 3 secs. |
2 participants
No description provided.