Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve fixture stairville/clb5-6p-rgb-ww-compact-led-bar #3897

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Improve fixture stairville/clb5-6p-rgb-ww-compact-led-bar #3897

merged 2 commits into from
Apr 5, 2024

Conversation

Subjekt91
Copy link

@Subjekt91 Subjekt91 commented Apr 5, 2024 •
edited
Loading

Hi @FloEdelmann! This PR supersedes the automatic one #3651
I revied the points as stated in #2429 and fixed 2 things ive missed, is there anything else i can do to get this merged ?

  • Checking whether at least 3 links are present. Otherwise, finding suitable links.
  • link to a manual PDF containing all DMX modes
  • link to a product page on the official manufacturer website
  • link to a YouTube or Vimeo video that showcases or explains the fixture
  • Checking whether all DMX modes from the manual are included in the fixture definition.
  • Checking whether all DMX modes' channels from the manual are included in the fixture definition.
  • Checking whether all DMX channels' capabilities from the manual are included in the fixture definition.

@luc122c luc122c changed the title Add fixture stairville/clb5-6p-rgb-ww-compact-led-bar Add fixture stairville/clb5-6p-rgb-ww-compact-led-bar Apr 5, 2024
@luc122c luc122c added the new-fixture Request or implementation to add a new fixture definition. label Apr 5, 2024
@luc122c
Copy link
Contributor

luc122c commented Apr 5, 2024

Thanks @Subjekt91 , I'll merge this into the existing branch so that it can be reviewed as one.

@luc122c luc122c merged commit 157c782 into OpenLightingProject:branch2023-11-26T23-31-35 Apr 5, 2024
@FloEdelmann FloEdelmann changed the title Add fixture stairville/clb5-6p-rgb-ww-compact-led-bar Improve fixture stairville/clb5-6p-rgb-ww-compact-led-bar Apr 17, 2024
@FloEdelmann FloEdelmann added component-fixture Affects one or more existing fixture definitions. and removed new-fixture Request or implementation to add a new fixture definition. labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component-fixture Affects one or more existing fixture definitions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Subjekt91 @luc122c @FloEdelmann