Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Statement Tweaks #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jidehen
Copy link

@jidehen jidehen commented Jun 5, 2019

Altered the primary key declarations in the create statements for better compatibility with tools like http://draw.io#app

jidehen added 2 commits June 5, 2019 16:51
Altered the primary key declarations in the create statements for better compatibility with tools like http://draw.io#app
@TallTed
Copy link
Member

TallTed commented Jun 11, 2019

@jidehen -- Your second commit doesn't solve the problems of your first, which did much more than "[alter] the primary key declarations".

Please look at the conflicts.

Note that the 3917 lines you added start and end with references to a "PostgreSQL database dump", which references appear nowhere in the 3447 lines you deleted -- nor in any of the other .sql files in this repo.

It appears to me that your 3917 lines do not belong in this file at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants