Fix DLL symbol name pre/postfixing in CMake builds on Windows #5191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harishmcw
changed the title
Harishmcw
changed the title
|
I can only assume that your force-push on the other PR triggered some unexpected behavior in git, as the CMakeLists change was still visible in the web interface when I triggered the merge. I'll add proper initialization of the REMOVE_STATIC_LIB variable later (indeed my draft PR only had it defined inside the conditional) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #5190, which supersedes #5188. However, the CMake changes from 5188 were not included in 5190. This PR ensures those missing changes are applied.
It modifies the CMake script to correctly handle symbol pre/post fixing for CMake builds.
Additionally, I have commented out #if (${REMOVE_STATIC_LIB}) as it was causing build errors. The REMOVE_STATIC_LIB variable is intended to control the removal of the static library, but it is not defined anywhere in the file, leading to build failures.