Skip to content

Conversation

@martin-frbg
Copy link
Collaborator

No description provided.

" cmp "J", xzr \n"
" beq 3f //dot_kernel_F1 \n"

"// .align 5 \n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge my PR (#5566) to avoid regressing quality on non-windows platforms? With #if !(defined(__clang__) && defined(OS_WINDOWS))

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

certainly - this is just the second part required for making the change do anything useful for WoA when compiled on device, where LLVM (and CMake) is currently the only option.
the huge diff due to CRLF line endings is also spurious and temporary - but I really had to prioritize unrelated work when you brought it up

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not actually the only option: I am using clang from WSL, so that I can use all the familiar make tools and linux environment on-device, with native support for .exe files running natively (via binfmt magic). Only oddness is needing to set CROSS=1 to compile, then CROSS=0 to run the tests.

I can share the details of the setup if you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants