-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NMS-16994: Export NMS Inventory and Alarms #7574
base: foundation-2024
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine.
Add another gRPC Client for Alarms/Inventory.
Rename existing GrpcExporterClient as GrpcExporter. This will handle config related to connection.
Existing grpc client code could be moved into BsmGrpcClient.
Create new AlarmInventoryGrpcClient which adds support for sending this proto.
let me know if you have any other questions.
Going to implement above changes as mentioned under here, kindly let me know if its fine, thanks:
Will push new changes into same PR. |
Chandra Gorantla seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
string foreign_type = 1; | ||
string foreign_source = 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove these two. We already know that the system type is OpenNMS
we can replace these with
string instance_id = 1;
string instance_name = 2;
Use RuntimeInfo.getSystemId()
to get instance id - It has to be UUID
Use SystemInfoUtils.getInstanceId() to get instance name. - This is by default OpenNMS
but user can update this to be a different name when dealing with multiple OpenNMS systems
External References