Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some official Docker images #2530

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Add some official Docker images #2530

merged 3 commits into from
Dec 4, 2023

Conversation

francoishernandez
Copy link
Member

@francoishernandez francoishernandez commented Nov 29, 2023

Several objectives, including:

  • facilitate setup and onboarding for any user, potentially simplify some docs/tutorials
  • facilitate reproducibility, issue reporting and bug fixes

This is a first version, we might want to adapt some things down the line, e.g.:

  • build for specific / multiple torch version(s) (currently defaulting to latest available)
  • faster/lighter build (relying on some official nvidia images? multi-stage? caching?)
  • some inference specific image(s), which would need less dependencies and hence could be significantly lighter;
  • test and adapt for other platforms (tested on a fairly standard linux amd64 server only for now)

Build is automatically triggered for every push on this docker branch to faciliate testing the workflow, but afterwards it will be handled via workflow_dispatch. It is intentionnaly decoupled from the release workflow, to facilitate manual builds down the line (e.g. for specicific torch/cuda versions, etc.)

@francoishernandez francoishernandez force-pushed the docker branch 3 times, most recently from 3e8c301 to 5f42619 Compare November 29, 2023 15:38
@vince62s
Copy link
Member

maybe add instructions on Docker usage in README ?

@francoishernandez
Copy link
Member Author

Latest commit 117be02 adds a bit of doc in the readme, as well as the install of all the optional requirements in the Dockerfile. This first version of the image(s) will serve as a kind of "exhaustive" dev platform, and we might create some lighter alternatives down the line.
Will merge and trigger the first build on v3.4.3.

@francoishernandez francoishernandez changed the title [WIP] Add some official Docker images Add some official Docker images Dec 4, 2023
@francoishernandez francoishernandez merged commit c568bc5 into master Dec 4, 2023
6 checks passed
@l-k-11235
Copy link
Contributor

Merci !

@anthdr
Copy link
Contributor

anthdr commented Dec 7, 2023

Pytorch images provided by nvidia already have everything built-in (including apex) which simplify even more the creation of the image, but seem to offer less flexibility regarding cuda & pytorch version (and I'm not sure the whole image can pass in the github action servers).
https://catalog.ngc.nvidia.com/orgs/nvidia/containers/pytorch
https://docs.nvidia.com/deeplearning/frameworks/support-matrix/index.html#framework-matrix-2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants