Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F-558: Add missing paramters in OS section of VM template #579

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jaypif
Copy link
Collaborator

@jaypif jaypif commented Nov 8, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for PR followers and do not help prioritize the request

Description

This PR adds support for missing OS section in VM template. It aligns the OS section with the Documentation:
https://docs.opennebula.io/6.10/management_and_operations/references/template.html?highlight=firmware#os-and-boot-options-section

A correct fix consist in updating GOCA OSVec structure to reflec the Documentation
A dedicated issue has bee openned in the Goca Repo: OpenNebula/one#6782

References

#558

New or Affected Resource(s)

  • opennebula_XXXXX

Checklist

  • I have created an issue and I have mentioned it in References
  • My code follows the style guidelines of this project (use go fmt)
  • My changes generate no new warnings or errors
  • I have updated the unit tests and they pass succesfuly
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation (if needed)
  • I have updated the changelog file

@jaypif jaypif force-pushed the F-558 branch 4 times, most recently from 7f05741 to 2d72746 Compare November 8, 2024 14:21
This commit adds support for missing OS section in VM template.
It aligns the OS section with the Documentation:
https://docs.opennebula.io/6.10/management_and_operations/references/template.html?highlight=firmware#os-and-boot-options-section

A correct fix consist in updating GOCA OSVec structure to reflec the
Documentation
A dedicated issue has bee openned in the Goca Repo:
OpenNebula/one#6782

Closes: F-558
Copy link

This pull request is stale because it has been open for 30 days with no activity and it is not in a milestone. Remove 'status: stale' label or comment, or this will be closed in 5 days.

@jschoewe
Copy link

Why does this keep getting stale and closed? Some of us have templates that need secure boot enabled in order to boot them after they're cloned. The work looks done, these fields were added to the one GOCA 2 months ago:
OpenNebula/one#6795
OpenNebula/one#6782

That issue was closed and added to the latest enterprise release (6.10.2) a month ago:
https://github.com/OpenNebula/one/milestone/80?closed=1

I cloned the branch from this PR, merged master into it, built the provider using this updated code, and tested it on Open Nebula 6.10.2.

It works great, I also tested on an earlier version (6.10.0) and that still works too. These new fields aren't required, this PR doesn't contain breaking changes, building and using a forked provider is a pain, people have been waiting months for this, I don't see any reason not to merge it anymore.

Merge this now please!

 
Testing:

Open Nebula version:
Image

Terraform apply result:
Image

Cloned template new OS fields 6.10.2:
Image

The OS fields for older versions will look like this and still work:
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants