liblrs: add more members and split admin #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flomonster
previously approved these changes
Nov 15, 2024
mxmehl
previously approved these changes
Dec 2, 2024
There was a problem hiding this comment.
LGTM. Just three comments:
- As @flomonster said, adding this file and the admin team to CODEOWNERS makes sense
- The
maintainergroup isn't really necessary as the member organisation happens via this file, and all manual changes will be overridden anyway. - You can also make the team names pretty-printed, e.g. "liblrs Admins", if you prefer.
Tristramg
force-pushed
the
push-otlllknnpkot
branch
from
3d0a273 to
7ac9416
Compare
Tristramg
force-pushed
the
push-otlllknnpkot
branch
from
7ac9416 to
e095694
Compare
|
Thank you for your feedback. I’m a bit confused by the warning by github saying that the team Isn’t defining them in teams/liblrs.yaml enough? |
|
Yes, that's enough. The problem is that your team hasn't been created yet, since the PR hasn't been merged. So GitHub warns you that a team in your CODEOWNERS doesn't exist (yet). |
mxmehl
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.