Vcs/zoom rectangle 3 #2975
anisometropieosrd-ui-build.yml
on: pull_request
build
1m 33s
check_commits
4s
Check final newline
10s
Check unit tests
33s
Check REUSE Compliance
7s
Check DCO
3s
Annotations
5 errors and 10 warnings
|
Check DCO
Process completed with exit code 1.
|
|
check_commits
Process completed with exit code 1.
|
|
src/__tests__/helpers.spec.ts > computeWaypointsToDisplay > should return correct heights for proportional display:
ui-manchette-with-spacetimechart/src/__tests__/helpers.spec.ts#L58
AssertionError: expected 'NaNpx' to be '428px' // Object.is equality
Expected: "428px"
Received: "NaNpx"
❯ src/__tests__/helpers.spec.ts:58:38
|
|
Check unit tests
Process completed with exit code 1.
|
|
build
Process completed with exit code 1.
|
|
build:
ui-spacetimechart/src/components/CanvasRect.tsx#L1
'React' is defined but never used
|
|
build:
ui-spacetimechart/src/components/CanvasRect.tsx#L34
'overlayRef' is assigned a value but never used
|
|
build:
ui-manchette-with-spacetimechart/src/hooks/useManchetteWithSpaceTimeChart.ts#L3
Replace `⏎··type·SpaceScale,⏎··type·SpaceTimeChartProps,⏎` with `·type·SpaceScale,·type·SpaceTimeChartProps·`
|
|
build:
ui-manchette-with-spacetimechart/src/hooks/useManchetteWithSpaceTimeChart.ts#L7
`@osrd-project/ui-manchette` import should occur before import of `@osrd-project/ui-spacetimechart`
|
|
build:
ui-manchette-with-spacetimechart/src/hooks/useManchetteWithSpaceTimeChart.ts#L30
There should be at least one empty line between import groups
|
|
build:
ui-manchette-with-spacetimechart/src/hooks/useManchetteWithSpaceTimeChart.ts#L31
There should be at least one empty line between import groups
|
|
build:
ui-manchette-with-spacetimechart/src/hooks/useManchetteWithSpaceTimeChart.ts#L31
`lodash` import should occur before import of `./usePaths`
|
|
build:
ui-manchette-with-spacetimechart/src/hooks/useManchetteWithSpaceTimeChart.ts#L32
`../utils` import should occur before import of `../utils/point`
|
|
build:
ui-manchette-with-spacetimechart/src/hooks/useManchetteWithSpaceTimeChart.ts#L109
Replace `·computeWaypointsToDisplay(waypoints,·{·height,·isProportional,·yZoom·},·minZoomMillimetrePerPx,·maxZoomMillimetrePerPx` with `⏎······computeWaypointsToDisplay(⏎········waypoints,⏎········{·height,·isProportional,·yZoom·},⏎········minZoomMillimetrePerPx,⏎········maxZoomMillimetrePerPx⏎······`
|
|
build:
ui-manchette-with-spacetimechart/src/hooks/useManchetteWithSpaceTimeChart.ts#L110
React Hook useMemo has missing dependencies: 'maxZoomMillimetrePerPx' and 'minZoomMillimetrePerPx'. Either include them or remove the dependency array
|