-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: split manchette with div #899
Conversation
56ac5f7
to
be29ae9
Compare
c90f979
to
aadf890
Compare
38f7953
to
c5c4899
Compare
c5c4899
to
78d882a
Compare
Thanks for your comments, we've taken them on board and fixed all the problems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this AC has not been processed.
"dans la story, l'utilisateur peut préciser la taille de l'élément et sa position"
I think the size part will be handled in the GET intergation. @clarani, what do you think? |
Done ! |
c497378
to
e796739
Compare
Yes it can be handled with the split of the GET 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
Signed-off-by: theocrsb <[email protected]>
898efe2
to
9604df9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
closes https://github.com/osrd-project/osrd-confidential/issues/697