Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-spacetimechart: upgrades time captions #945

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

jacomyal
Copy link
Contributor

This commit implements new designs from @thibautsailly, and addresses issue OpenRailAssociation/osrd#10663.

Details:

  • Updates styles matrices for time captions and graduations
  • Adds date labels
  • Adds new option hideDates to hide date labels, adds it to the options story
  • Adds some margin around the time captions stage, so that captions of times right outside the stage are still visible while panning
  • Fixes path labels when axis are swapped

This commit implements new designs from @thibautsailly, and addresses
issue OpenRailAssociation/osrd#10663.

Details:
- Updates styles matrices for time captions and graduations
- Adds date labels
- Adds new option `hideDates` to hide date labels, adds it to the
  options story
- Adds some margin around the time captions stage, so that captions of
  times right outside the stage are still visible while panning
- Fixes path labels when axis are swapped

Signed-off-by: Alexis Jacomy <[email protected]>
@jacomyal jacomyal requested review from Yohh and clarani February 28, 2025 09:43
@jacomyal jacomyal requested a review from a team as a code owner February 28, 2025 09:43
@Yohh Yohh self-assigned this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants