ui-warped-map: move stories to storybook #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks stories importing @osrd-project/ui-manchette: they use an old cache and don't realize ui-manchette's dist/ directory has changed. Signed-off-by: Simon Ser <[email protected]>
This stuff is used by stories, so might be useful for real users as well. Signed-off-by: Simon Ser <[email protected]>
This way we can use proper imports from '@osrd-project/ui-warped-map' instead of accessing directly internal files. Signed-off-by: Simon Ser <[email protected]>
Don't access internal ui-manchette files from the story. Signed-off-by: Simon Ser <[email protected]>
SharglutDev
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus some other loosely related cleanup.
See individual commits.