Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storybook: move manchette's stories into /storybook #959

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

storybook: move manchette's stories into /storybook #959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0a2d7c
package-lock: remove viteste from ui-charts dev-dependencies
clarani Mar 5, 2025
da76372
ui-charts: remove Waypoint and WaypointsList stories
clarani Mar 5, 2025
588f947
storybook: move manchette's stories into /storybook
clarani Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 0 additions & 34 deletions storybook/stories/ManchetteSplit/sampleData.ts
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion ...e/Manchette/stories/Manchette.stories.tsx → ...ui-charts/manchette/Manchette.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { Manchette } from '@osrd-project/ui-charts';
import '@osrd-project/ui-core/dist/theme.css';
import '@osrd-project/ui-charts/dist/theme.css';
import type { Meta, StoryObj } from '@storybook/react';

import { SAMPLE_WAYPOINTS } from './assets/sampleData';
import Manchette from '../components/Manchette';

const meta: Meta<typeof Manchette> = {
component: Manchette,
Expand Down
10 changes: 5 additions & 5 deletions ...ManchetteSplit/ManchetteSplit.stories.tsx → ...arts/manchette/ManchetteSplit.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { Manchette } from '@osrd-project/ui-charts';
import '@osrd-project/ui-core/dist/theme.css';
import type { Meta, StoryObj } from '@storybook/react';

import WAYPOINTS_DATA from './sampleData';
import { SAMPLE_WAYPOINTS } from './assets/sampleData';

const meta: Meta<typeof Manchette> = {
component: Manchette,
Expand All @@ -26,12 +26,12 @@ const customDiv = (
export const Default: Story = {
args: {
contents: [
WAYPOINTS_DATA[0],
SAMPLE_WAYPOINTS[0],
customDiv,
WAYPOINTS_DATA[1],
WAYPOINTS_DATA[2],
SAMPLE_WAYPOINTS[1],
SAMPLE_WAYPOINTS[2],
customDiv,
WAYPOINTS_DATA[3],
SAMPLE_WAYPOINTS[3],
customDiv,
],
},
Expand Down
2 changes: 1 addition & 1 deletion ...te/Manchette/stories/assets/sampleData.ts → .../ui-charts/manchette/assets/sampleData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { type Waypoint } from '../../types';
import { type Waypoint } from '@osrd-project/ui-charts';

export const SAMPLE_WAYPOINTS: Waypoint[] = [
{
Expand Down
0 ...chetteWithSpaceTimeChart/stories/Menu.tsx → ...arts/manchetteWithSpaceTimeChart/Menu.tsx
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...teWithSpaceTimeChart/assets/sampleData.ts → ...teWithSpaceTimeChart/assets/sampleData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { type ProjectPathTrainResult, type Waypoint } from '../../Manchette';
import { type ProjectPathTrainResult, type Waypoint } from '@osrd-project/ui-charts';

export const SAMPLE_WAYPOINTS: Waypoint[] = [
{
Expand Down
15 changes: 10 additions & 5 deletions ...ories/base-with-waypoint-menu.stories.tsx → ...Chart/base-with-waypoint-menu.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,22 @@
import React, { useEffect, useRef, useState } from 'react';

import {
PathLayer,
SpaceTimeChart,
Manchette,
type ProjectPathTrainResult,
type Waypoint,
useManchetteWithSpaceTimeChart,
} from '@osrd-project/ui-charts';
import { EyeClosed, Telescope } from '@osrd-project/ui-icons';
import type { Meta } from '@storybook/react';
import '@osrd-project/ui-core/dist/theme.css';
import '@osrd-project/ui-charts/dist/theme.css';
import cx from 'classnames';
import { createPortal } from 'react-dom';

import { SAMPLE_PATHS_DATA, SAMPLE_WAYPOINTS } from './assets/sampleData';
import Menu, { type MenuItem } from './Menu';
import { PathLayer, SpaceTimeChart } from '../../../spaceTimeChart';
import Manchette, { type ProjectPathTrainResult, type Waypoint } from '../../Manchette';
import { SAMPLE_WAYPOINTS, SAMPLE_PATHS_DATA } from '../assets/sampleData';
import useManchettesWithSpaceTimeChart from '../hooks/useManchetteWithSpaceTimeChart';

type ManchetteWithSpaceTimeWrapperProps = {
waypoints: Waypoint[];
Expand Down Expand Up @@ -63,7 +68,7 @@ const ManchetteWithSpaceTimeWrapper = ({
setActiveWaypointId(waypointId);
};

const { manchetteProps, spaceTimeChartProps, handleScroll } = useManchettesWithSpaceTimeChart(
const { manchetteProps, spaceTimeChartProps, handleScroll } = useManchetteWithSpaceTimeChart(
waypoints,
projectPathTrainResult,
manchetteWithSpaceTimeChartRef,
Expand Down
18 changes: 11 additions & 7 deletions ...thSpaceTimeChart/stories/base.stories.tsx → ...chetteWithSpaceTimeChart/base.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
import React, { useRef } from 'react';

import type { Meta } from '@storybook/react';

import '@osrd-project/ui-core/dist/theme.css';
import '@osrd-project/ui-charts/dist/theme.css';
import {
PathLayer,
SpaceTimeChart,
Manchette,
useManchetteWithSpaceTimeChart,
type ProjectPathTrainResult,
type Waypoint,
} from '@osrd-project/ui-charts';
import type { Meta } from '@storybook/react';

import { PathLayer, SpaceTimeChart } from '../../../spaceTimeChart';
import Manchette, { type ProjectPathTrainResult, type Waypoint } from '../../Manchette';
import { SAMPLE_WAYPOINTS, SAMPLE_PATHS_DATA } from '../assets/sampleData';
import useManchettesWithSpaceTimeChart from '../hooks/useManchetteWithSpaceTimeChart';
import { SAMPLE_WAYPOINTS, SAMPLE_PATHS_DATA } from './assets/sampleData';

type ManchetteWithSpaceTimeWrapperProps = {
waypoints: Waypoint[];
Expand All @@ -25,7 +29,7 @@ const ManchetteWithSpaceTimeWrapper = ({
}: ManchetteWithSpaceTimeWrapperProps) => {
const manchetteWithSpaceTimeChartRef = useRef<HTMLDivElement>(null);

const { manchetteProps, spaceTimeChartProps, handleScroll } = useManchettesWithSpaceTimeChart(
const { manchetteProps, spaceTimeChartProps, handleScroll } = useManchetteWithSpaceTimeChart(
waypoints,
projectPathTrainResult,
manchetteWithSpaceTimeChartRef,
Expand Down
9 changes: 4 additions & 5 deletions ...SpaceTimeChart/stories/simple.stories.tsx → ...etteWithSpaceTimeChart/simple.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import type { Meta } from '@storybook/react';

import '@osrd-project/ui-core/dist/theme.css';
import { ManchetteWithSpaceTimeChart } from '@osrd-project/ui-charts';
import '@osrd-project/ui-charts/dist/theme.css';
import '@osrd-project/ui-core/dist/theme.css';
import type { Meta } from '@storybook/react';

import { SAMPLE_WAYPOINTS, SAMPLE_PATHS_DATA } from '../assets/sampleData';
import ManchetteWithSpaceTimeChart from '../components/ManchetteWithSpaceTimeChart';
import { SAMPLE_WAYPOINTS, SAMPLE_PATHS_DATA } from './assets/sampleData';

const meta: Meta<typeof ManchetteWithSpaceTimeChart> = {
title: 'Manchette with SpaceTimeChart/simple',
Expand Down
21 changes: 0 additions & 21 deletions ui-charts/src/manchette/Manchette/stories/Waypoint.stories.ts
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions ui-charts/src/manchette/Manchette/stories/WaypointList.stories.ts
View file
Open in desktop

This file was deleted.