Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: bump nge version to 2.9.21 #10558

Merged
merged 1 commit into from
Feb 4, 2025
Merged

front: bump nge version to 2.9.21 #10558

merged 1 commit into from
Feb 4, 2025

Conversation

louisgreiner
Copy link
Contributor

@louisgreiner louisgreiner commented Jan 28, 2025

To test this change, you can follow the video, demonstrating a new feature of NGE that aligns the selected nodes using the arrow keys (up/down/right/left). This feature has been modified to emit operations that can be handled by OSRD

Enregistrement.de.l.ecran.2025-01-28.171838.mp4

Close #10588

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 28, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.86%. Comparing base (892a5a6) to head (49a219b).
Report is 33 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10558      +/-   ##
==========================================
- Coverage   81.87%   81.86%   -0.01%     
==========================================
  Files        1074     1074              
  Lines      107132   107132              
  Branches      728      728              
==========================================
- Hits        87712    87704       -8     
- Misses      19381    19389       +8     
  Partials       39       39              
Flag Coverage Δ
editoast 74.27% <ø> (-0.03%) ⬇️
front 89.38% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@louisgreiner louisgreiner marked this pull request as ready for review January 28, 2025 16:26
@louisgreiner louisgreiner requested a review from a team as a code owner January 28, 2025 16:26
Copy link
Contributor

@RomainValls RomainValls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works fine 👍

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

@louisgreiner louisgreiner added this pull request to the merge queue Jan 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2025
@louisgreiner louisgreiner added this pull request to the merge queue Feb 4, 2025
Merged via the queue into dev with commit b8eb493 Feb 4, 2025
27 checks passed
@louisgreiner louisgreiner deleted the lgr/bump-nge-2.9.21 branch February 4, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front, nge: 3 hacks + update nge fork
4 participants