sql_cacher: fix SQL result leak when insert_in_cachedb fails #3289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benceszigeti
force-pushed
the
hotfix/sql-cacher_load_entire_table_memory_leak
branch
from
e8ece98 to
d373ab6
Compare
bogdan-iancu
added a commit
that referenced
this pull request
Jan 23, 2024
…tire_table_memory_leak sql_cacher: fix SQL result leak when insert_in_cachedb fails (cherry picked from commit 3bef4af)
bogdan-iancu
added a commit
that referenced
this pull request
Jan 23, 2024
…tire_table_memory_leak sql_cacher: fix SQL result leak when insert_in_cachedb fails (cherry picked from commit 3bef4af)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After reviewing the
sql_cacherreload, found an error case where we early return with-1, but thesql_resis not cleaned up as in other cases. This also impacts the reporting of the unsuccessful load/reload.Details
N/A
Solution
Clean up the SQL result when
insert_in_cachedbfails.Compatibility
Found in 3.2, exists in master.
Closing issues
N/A